Re: [PATCH 00/11] Rid W=1 warnings from Block

From: Lee Jones
Date: Tue Mar 30 2021 - 09:22:23 EST


On Fri, 12 Mar 2021, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (11):
> block: rsxx: core: Remove superfluous const qualifier
> block: drbd: drbd_interval: Demote some kernel-doc abuses and fix
> another header
> block: mtip32xx: mtip32xx: Mark debugging variable 'start' as
> __maybe_unused
> block: drbd: drbd_state: Fix some function documentation issues
> block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers
> block: drbd: drbd_main: Remove duplicate field initialisation
> block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit
> block: drbd: drbd_main: Fix a bunch of function documentation
> discrepancies
> block: drbd: drbd_receiver: Demote less than half complete kernel-doc
> header
> block: xen-blkfront: Demote kernel-doc abuses
> block: drbd: drbd_nl: Demote half-complete kernel-doc headers

Would you like me to resubmit these?

> drivers/block/drbd/drbd_interval.c | 8 +++++---
> drivers/block/drbd/drbd_main.c | 30 +++++++++++++++---------------
> drivers/block/drbd/drbd_nl.c | 17 ++++++++++-------
> drivers/block/drbd/drbd_receiver.c | 26 ++++++++++++--------------
> drivers/block/drbd/drbd_state.c | 7 ++++---
> drivers/block/mtip32xx/mtip32xx.c | 2 +-
> drivers/block/rsxx/core.c | 2 +-
> drivers/block/xen-blkfront.c | 6 +++---
> 8 files changed, 51 insertions(+), 47 deletions(-)
>
> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Cc: drbd-dev@xxxxxxxxxxxxxxxx
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Cc: Joshua Morris <josh.h.morris@xxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>
> Cc: linux-block@xxxxxxxxxxxxxxx
> Cc: Philip Kelleher <pjk1939@xxxxxxxxxxxxx>
> Cc: Philipp Reisner <philipp.reisner@xxxxxxxxxx>
> Cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog