RE: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version

From: David Laight
Date: Tue Mar 30 2021 - 10:19:48 EST


From: richard.gong@xxxxxxxxxxxxxxx
> Sent: 30 March 2021 15:33
>
> Extend Intel service layer driver to get the firmware version running at
> FPGA device. Therefore FPGA manager driver, one of Intel service layer
> driver's client, can decide whether to handle the newly added bitstream
> authentication function based on the retrieved firmware version.

Using the version number to detect features is just plain wrong.

You should use something like a bitmap of supported features.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)