Re: [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver

From: Mukunda,Vijendar
Date: Tue Mar 30 2021 - 11:25:47 EST




On 3/30/21 7:52 PM, Pierre-Louis Bossart wrote:

  static const struct acpi_device_id acp3x_audio_acpi_match[] = {
      { "AMDI5682", (unsigned long)&acp3x_5682},
      { "AMDI1015", (unsigned long)&acp3x_1015},
+    { "AMDP1015", (unsigned long)&acp3x_1015p},

This isn't a valid ACPI ID. AMDP does not exist in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuefi.org%2Facpi_id_list&data=04%7C01%7CVijendar.Mukunda%40amd.com%7C7406bd8053104c021c6c08d8f3875396%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637527109839548809%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WXNykTVcn4tgxIHPsJVXaDf9J5a63c29IMUOhJ3X8LU%3D&reserved=0

There was a similar issue with Intel platforms using this part, we had to use a different HID.


Is it okay if i use "AMDI1016" for ALC1015P?