Re: [PATCH v1 2/3] mux: gpio: Make it OF independent
From: Peter Rosin
Date: Tue Mar 30 2021 - 12:12:07 EST
Hi!
On 2021-03-26 18:24, Andy Shevchenko wrote:
> Module doesn't use OF APIs anyhow, make it OF independent by replacing
> headers and dropping useless of_match_ptr() call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/mux/gpio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
> index 891ee0274733..e5ef9284e2b4 100644
> --- a/drivers/mux/gpio.c
> +++ b/drivers/mux/gpio.c
> @@ -10,8 +10,8 @@
> #include <linux/err.h>
> #include <linux/gpio/consumer.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
mod_devicetable.h sorts before module.h. With that changed,
Acked-by: Peter Rosin <peda@xxxxxxxxxx>
Cheers,
Peter
> #include <linux/mux/driver.h>
> -#include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
>
> @@ -97,7 +97,7 @@ static int mux_gpio_probe(struct platform_device *pdev)
> static struct platform_driver mux_gpio_driver = {
> .driver = {
> .name = "gpio-mux",
> - .of_match_table = of_match_ptr(mux_gpio_dt_ids),
> + .of_match_table = mux_gpio_dt_ids,
> },
> .probe = mux_gpio_probe,
> };
>