Re: [PATCH v2 0/6] mips: bmips: fix and improve reboot nodes
From: Florian Fainelli
Date: Tue Mar 30 2021 - 13:14:53 EST
On 3/30/21 6:09 AM, Thomas Bogendoerfer wrote:
> On Sun, Mar 14, 2021 at 05:43:45PM +0100, Álvaro Fernández Rojas wrote:
>> These patches improve bmips bcm63xx device tree nodes.
>>
>> v2: add missing BCM63268 patch.
>>
>> Álvaro Fernández Rojas (6):
>> mips: bmips: fix syscon-reboot nodes
>> mips: bmips: bcm6328: populate device tree nodes
>> mips: bmips: bcm6358: populate device tree nodes
>> mips: bmips: bcm6362: populate device tree nodes
>> mips: bmips: bcm6368: populate device tree nodes
>> mips: bmips: bcm63268: populate device tree nodes
>>
>> arch/mips/boot/dts/brcm/bcm3368.dtsi | 2 +-
>> arch/mips/boot/dts/brcm/bcm63268.dtsi | 132 +++++++++++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6328.dtsi | 119 ++++++++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6358.dtsi | 85 ++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6362.dtsi | 129 ++++++++++++++++++++++---
>> arch/mips/boot/dts/brcm/bcm6368.dtsi | 129 ++++++++++++++++++++++---
>> 6 files changed, 530 insertions(+), 66 deletions(-)
>
> Florian, are you ok with this changes ? If yes, I'm going to apply them
> to mips-next.
This all looks good to me and matches the hardware manuals as far as
resources are declared. There may be some room for doing a bit more
consolidation since there is not that much difference between SoCs after
all, maybe as a subsequent change.
--
Florian