Re: [PATCH 2/3] MIPS: uaccess: Remove get_fs/set_fs call sites

From: Thomas Bogendoerfer
Date: Tue Mar 30 2021 - 16:47:08 EST


On Tue, Mar 30, 2021 at 07:49:43PM +0200, Christoph Hellwig wrote:
> On Tue, Mar 30, 2021 at 07:26:59PM +0200, Thomas Bogendoerfer wrote:
> > +#define __get_data(x, ptr, u) \
> > + (((u) == true) ? __get_udata((x), (ptr), sizeof(*(ptr))) : \
> > + __get_kdata((x), (ptr), sizeof(*(ptr))))
> > +
>
> I'm a little worried about exposing this in uaccess.h. Can you
> have local helpers insted, preferably strongly typed for their
> specific use cases?

sure, no problem.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]