Re: [PATCH v2 0/3] Misc bug fixes in mtk power domain driver

[Enric Balletbo Serra]

Hi Bilal,

Thank you for your patch.

Missatge de Bilal Wasim <bilalwasim676@xxxxxxxxx> del dia dt., 16 de
febr. 2021 a les 13:00:
>
>
> ping - can this series be merged ?
>

This series breaks my display with the current mainline. With those
patches applied my display doesn't turn on and I get the following
error. Note that in mainline we don't have a gpu working driver.

[   66.979546] ------------[ cut here ]------------
[   66.984234] [CRTC:43:crtc-0] vblank wait timed out
[   66.989070] WARNING: CPU: 2 PID: 432 at
drivers/gpu/drm/drm_atomic_helper.c:1512
drm_atomic_helper_wait_for_vblanks.part.0+0x278/0x2a0
[   67.001166] Modules linked in: af_alg mwifiex_sdio mwifiex
btmrvl_sdio btmrvl bluetooth mtk_vcodec_dec mtk_vcodec_enc cfg80211
uvcvideo mtk
_mdp mtk_vcodec_common v4l2_h264 v4l2_mem2mem videobuf2_dma_contig
videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common
videodev
 smsc ecdh_generic mt8173_rt5650 ecc smsc95xx rfkill mc usbnet
cros_ec_sensors snd_soc_rt5645 cros_ec_sensors_core elants_i2c
mt8173_afe_pcm c
rct10dif_ce elan_i2c industrialio_triggered_buffer sbs_battery
cros_ec_chardev kfifo_buf cros_usbpd_charger cros_usbpd_logger
snd_soc_rl6231 s
nd_soc_mtk_common mtk_vpu display_connector pwm_bl fuse ip_tables x_tables ipv6
[   67.057686] CPU: 2 PID: 432 Comm: gnome-shell Tainted: G        W
      5.12.0-rc5+ #25
[   67.065861] Hardware name: Google Elm (DT)
[   67.069950] pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--)
[   67.075952] pc :
drm_atomic_helper_wait_for_vblanks.part.0+0x278/0x2a0
[   67.082477] lr :
drm_atomic_helper_wait_for_vblanks.part.0+0x278/0x2a0
[   67.089000] sp : ffff800012c23aa0
[   67.092308] x29: ffff800012c23aa0 x28: 0000000000000004
[   67.097621] x27: 0000000000000000 x26: 0000000000000001
[   67.102933] x25: 0000000000000038 x24: ffff0000c4726000
[   67.108246] x23: 0000000000000001 x22: 0000000000000000
[   67.113558] x21: ffff0000cabbd880 x20: ffff0000c3bd8080
[   67.118869] x19: 0000000000000000 x18: 0000000000000000
[   67.124180] x17: 0000000000000010 x16: 0000000000000000
[   67.129492] x15: 0000000000000030 x14: ffffffffffffffff
[   67.134805] x13: ffff800011ce2680 x12: 00000000000007c2
[   67.140117] x11: 0000000000000296 x10: ffff800011d3a680
[   67.145428] x9 : 00000000fffff000 x8 : ffff800011ce2680
[   67.150741] x7 : ffff800011d3a680 x6 : 0000000000000000
[   67.156052] x5 : 0000000000000000 x4 : ffff0000ff77c918
[   67.161364] x3 : ffff0000ff783878 x2 : 0000000000000000
[   67.166674] x1 : 0000000000000000 x0 : ffff0000cc660000
[   67.171985] Call trace:
[   67.174426]  drm_atomic_helper_wait_for_vblanks.part.0+0x278/0x2a0
[   67.180603]  drm_atomic_helper_commit_tail_rpm+0x80/0xa0
[   67.185913]  commit_tail+0xa0/0x180
[   67.189399]  drm_atomic_helper_commit+0x160/0x370
[   67.194100]  drm_atomic_commit+0x4c/0x60
[   67.198022]  drm_mode_obj_set_property_ioctl+0x164/0x460
[   67.203330]  drm_ioctl_kernel+0xc4/0x11c
[   67.207251]  drm_ioctl+0x210/0x430
[   67.210650]  __arm64_sys_ioctl+0xa8/0xec
...

Thanks,
  Enric

> On Mon,  1 Feb 2021 17:14:13 +0500
> Bilal Wasim <bilalwasim676@xxxxxxxxx> wrote:
>
> > Incorrect mask for the "bus_prot_clr" field meant that imgtec
> > gpu power domain (mfg_async) was not powered up correctly, causing
> > failure in driver booting. Fixing this and also adding "domain_suuply"
> > capability to "mfg_async" power domain (for mt8173) as imgtec gpu
> > needs da9211 regulator to be enabled before enabling this subdomain.
> >
> > Tested with mt8173 elm chromebook.
> >
> > Bilal Wasim (3):
> >   soc: mediatek: pm-domains: Use correct mask for bus_prot_clr
> >   soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD
> >   arm64: dts: mediatek: mt8173: Add domain supply for mfg_async
> >
> >  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 ++++
> >  arch/arm64/boot/dts/mediatek/mt8173-evb.dts  | 4 ++++
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi     | 2 +-
> >  drivers/soc/mediatek/mt8173-pm-domains.h     | 1 +
> >  drivers/soc/mediatek/mtk-pm-domains.h        | 2 +-
> >  5 files changed, 11 insertions(+), 2 deletions(-)
> >
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-mediatek