Re: [PATCH 1/3] gpio: tqmx86: really make IRQ optional

[Andy Shevchenko]

On Wed, Mar 31, 2021 at 2:37 PM Matthias Schiffer
<matthias.schiffer@xxxxxxxxxxxxxxx> wrote:
>
> The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This
> causes warnings with newer kernels.
>
> Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a
> missing IRQ properly.

...

> -       irq = platform_get_irq(pdev, 0);
> -       if (irq < 0)
> +       irq = platform_get_irq_optional(pdev, 0);

> +       if (irq < 0 && irq != -ENXIO)
>                 return irq;

This is a dead code now. I suggest you to do the opposite, i.e.
if (irq < 0)
  irq = 0;

In such a case below change is not required.

...

> -       if (irq) {
> +       if (irq > 0) {
>                 struct irq_chip *irq_chip = &gpio->irq_chip;
>                 u8 irq_status;


-- 
With Best Regards,
Andy Shevchenko