Re: [PATCH v1 1/1] driver core: platform: Declare early_platform_cleanup() prototype

[Guenter Roeck]

On Wed, Mar 31, 2021 at 06:05:25PM +0300, Andy Shevchenko wrote:
> Compiler is not happy:
> 
>   CC      drivers/base/platform.o
> drivers/base/platform.c:1557:20: warning: no previous prototype for ‘early_platform_cleanup’ [-Wmissing-prototypes]
>  1557 | void __weak __init early_platform_cleanup(void) { }
>       |                    ^~~~~~~~~~~~~~~~~~~~~~
> 
> Declare early_platform_cleanup() prototype in the header to make everyone happy.
> 
> Fixes: eecd37e105f0 ("drivers: Fix boot problem on SuperH")
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  include/linux/platform_device.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 3f23f6e430bf..cd81e060863c 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -359,4 +359,7 @@ static inline int is_sh_early_platform_device(struct platform_device *pdev)
>  }
>  #endif /* CONFIG_SUPERH */
>  
> +/* For now only SuperH uses it */
> +void early_platform_cleanup(void);
> +
>  #endif /* _PLATFORM_DEVICE_H_ */
> -- 
> 2.30.2
>