Re: [PATCH] crypto: ccp -A value assigned to a variable is never used.

[John Allen]

On Tue, Mar 30, 2021 at 06:10:29PM +0800, Jiapeng Chong wrote:
> Fix the following whitescan warning:
> 
> Assigning value "64" to "dst.address" here, but that stored value is
> overwritten before it can be used.
> 

Thanks for reporting.

Acked-by: John Allen <john.allen@xxxxxxx>

> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/crypto/ccp/ccp-ops.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index d6a8f4e..bb88198 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -2418,7 +2418,6 @@ static int ccp_run_ecc_pm_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
>  	dst.address += CCP_ECC_OUTPUT_SIZE;
>  	ccp_reverse_get_dm_area(&dst, 0, ecc->u.pm.result.y, 0,
>  				CCP_ECC_MODULUS_BYTES);
> -	dst.address += CCP_ECC_OUTPUT_SIZE;
>  
>  	/* Restore the workarea address */
>  	dst.address = save;
> -- 
> 1.8.3.1
>