Re: [PATCHv4 1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings

From: Andrew Lunn
Date: Wed Mar 31 2021 - 18:41:30 EST


On Mon, Mar 29, 2021 at 07:16:48PM -0700, Grant Grundler wrote:
> From: Oliver Neukum <oneukum@xxxxxxxx>
>
> The generic functions assumed devices provided an MDIO interface (accessed
> via older mii code, not phylib). This is true only for genuine ethernet.
>
> Devices with a higher level of abstraction or based on different
> technologies do not have MDIO. To support this case, first rename
> the existing functions with _mii suffix.
>
> v2: rebased on changed upstream
> v3: changed names to clearly say that this does NOT use phylib
> v4: moved hunks to correct patch; reworded commmit messages
>
> Signed-off-by : Oliver Neukum <oneukum@xxxxxxxx>
> Tested-by: Roland Dreier <roland@xxxxxxxxxx>
> Reviewed-by: Grant Grundler <grundler@xxxxxxxxxxxx>
> Tested-by: Grant Grundler <grundler@xxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew