Re: [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation
From: Al Viro
Date: Wed Mar 31 2021 - 22:20:21 EST
On Wed, Mar 31, 2021 at 02:24:18PM -0600, Jonathan Corbet wrote:
> Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:
>
> > Fix kernel-doc warnings in fs/namespace.c:
> >
> > ./fs/namespace.c:1379: warning: Function parameter or member 'm' not described in 'may_umount_tree'
> > ./fs/namespace.c:1379: warning: Excess function parameter 'mnt' description in 'may_umount_tree'
> > ./fs/namespace.c:1950: warning: Function parameter or member 'path' not described in 'clone_private_mount'
> >
> > Also convert path_is_mountpoint() comments to kernel-doc.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Cc: Jonathan Corbet <corbet@xxxxxxx>
> > Cc: linux-doc@xxxxxxxxxxxxxxx
> > ---
> > Jon, Al has OK-ed you to merge this patch (and the next one, please).
> >
> > fs/namespace.c | 14 ++++++++------
> > 1 file changed, 8 insertions(+), 6 deletions(-)
>
> An actual acked-by would have been nice, oh well. Meanwhile, I've
> applied them with fixes to the typos in both changelogs :)
Generally speaking, I'm only glad to leave handling kernel-doc patches
to somebody else, especially when they are that trivial ;-)
Anyway,
Acked-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>