Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

From: Shakeel Butt
Date: Wed Mar 31 2021 - 23:05:41 EST


On Wed, Mar 31, 2021 at 8:02 PM Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
>
> Christian Borntraeger reported a warning about "percpu ref
> (obj_cgroup_release) <= 0 (-1) after switching to atomic".
> Because we forgot to obtain the reference to the objcg and
> wrongly obtain the reference of memcg.
>
> Reported-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

Looks good to me.

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>