Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
From: Greg KH
Date: Wed Apr 07 2021 - 13:51:43 EST
On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li.xe@xxxxxxxxxxx wrote:
> +/**
> + * struct rsmu_cdev - Driver data for RSMU character device
> + * @name: rsmu device name
Why not use the miscdev name field?
> + * @dev: pointer to platform device
So it's a parent? Why not make this a real platform_device pointer and
not a device pointer?
> + * @mfd: pointer to MFD device
You are properly handling the reference count of this and the platform
device pointer when you save it off, right? Please check.
> + * @miscdev: character device handle
> + * @lock: mutex to protect operations from being interrupted
What operations?
> + * @type: rsmu device type
> + * @ops: rsmu device methods
> + * @index: rsmu device index
Index into what?
> --- /dev/null
> +++ b/drivers/misc/rsmu_cm.c
> @@ -0,0 +1,166 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * This driver is developed for the IDT ClockMatrix(TM) of
> + * timing and synchronization devices.
> + *
> + * Copyright (C) 2019 Integrated Device Technology, Inc., a Renesas Company.
Note, it's 2021 :)
thanks,
greg k-h