Re: [PATCH v3 2/3] dt-bindings: touchscreen: Add HY46XX bindings

[Giulio Benetti]

On 4/7/21 8:56 PM, Rob Herring wrote:
> On Wed, Apr 7, 2021 at 12:57 PM Giulio Benetti
> <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> > Hello Rob, All,
> >
> > On 4/6/21 3:24 PM, Rob Herring wrote:
> > > On Fri, 02 Apr 2021 18:16:26 +0200, Giulio Benetti wrote:
> > > > This adds device tree bindings for the Hycon HY46XX touchscreen series.
> > > >
> > > > Signed-off-by: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx>
> > > > ---
> > > > V1->V2:
> > > > As suggested by Rob Herring:
> > > > * fixed $id: address
> > > > * added "hycon," in front of every custom property
> > > > * changed all possible property to boolean type
> > > > * removed proximity-sensor-switch property since it's not handled in driver
> > > > V2->V3:
> > > > As suggested by Jonathan Neuschäfer:
> > > > * fixed some typo
> > > > * fixed description indentation
> > > > * improved boolean properties descriptions
> > > > * improved hycon,report-speed description
> > > > ---
> > > >    .../input/touchscreen/hycon,hy46xx.yaml       | 120 ++++++++++++++++++
> > > >    MAINTAINERS                                   |   6 +
> > > >    2 files changed, 126 insertions(+)
> > > >    create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.example.dt.yaml:0:0: /example-0/i2c/hycon-hy4633@1c: failed to match any schema with compatible: ['hycon,hy4633']
> > >
> > > See https://patchwork.ozlabs.org/patch/1461797
> > >
> > > This check can fail if there are any dependencies. The base for a patch
> > > series is generally the most recent rc1.
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > date:
> >
> > I've just send corrected patches.
> >
> > Anyway I'd like to understand how to make dt_binding_check works correctly.
> >
> > I've installed yamllint and 'make dt_binding_check' works but it still
> > doesn't show that error up on compatible string.
> >
> > yamllint I have is version 1.20.0
> >
> > > pip3 install dtschema --upgrade
> >
> > I've already tried with that too and dtschema version is:
> > 1.3.8
>
> Huh? dtschema versions are YYYY.MM.

Sorry, it is 2021.3

> > I've read that dtc must be compiled with YAML output enabled and it
> > seems to be so, since when I issue 'make dt_binding_check' from my file:
> > hycon,hy46xx.yaml(with compatible string wrong "hycon,hy4633")
>
> It's a new check queued for 5.13 in linux-next. See commit
> c59773d204cc ("kbuild: Enable DT undocumented compatible checks").
>
> I've updated the bot email with this, but after I sent this one.

Ah ok, thank you, I'll apply it in my Repos.

Best regards
--
Giulio Benetti
Benetti Engineering sas