Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

[Andy Shevchenko]

On Thu, Apr 8, 2021 at 10:17 AM Yicong Yang <yangyicong@xxxxxxxxxxxxx> wrote:
> On 2021/4/8 7:04, Wolfram Sang wrote:
> >
> >> Reason for temp variable is for me it's confusing to see statement like
> >> "rate_khz = rate_khz / 1000".
> >
> > Yes. And with this clearer calculation, we can maybe skip the HZ_PER_KHZ
> > define completely and just use plain '1000' as a factor/divider because
> > it then becomes obvious. I still find the define more confusing than
> > helpful TBH. But I'll leave the final decision to Yicong Yang.
> >
>
> HZ_PER_KHZ macro are defined separately in other places of the kernel.
> Andy suggested to have this defined and used so that one day we can factor
> this macro out to the public. :)

Right, and I'm still for the idea to have a macro defined.

-- 
With Best Regards,
Andy Shevchenko