Re: [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe()

[Shenhar, Talel]

On 4/8/2021 1:01 PM, Ruiqi Gong wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Ruiqi Gong <gongruiqi1@xxxxxxxxxx>
> ---
>   drivers/thermal/thermal_mmio.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
> index d0bdf1ea3331..ded1dd0d4ef7 100644
> --- a/drivers/thermal/thermal_mmio.c
> +++ b/drivers/thermal/thermal_mmio.c
> @@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
>
>          resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>          sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
> -       if (IS_ERR(sensor->mmio_base)) {
> -               dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
> -                       PTR_ERR(sensor->mmio_base));
> +       if (IS_ERR(sensor->mmio_base))
>                  return PTR_ERR(sensor->mmio_base);
> -       }
>
>          sensor_init_func = device_get_match_data(&pdev->dev);
>          if (sensor_init_func) {
Acked-by: Talel Shenhar <talel@xxxxxxxxxx>