Re: [RFC v3 net-next 0/4] MT7530 interrupt support

[René van Dorst]

Quoting DENG Qingfang <dqfext@xxxxxxxxx>:

> Add support for MT7530 interrupt controller.
>
> DENG Qingfang (4):
>   net: phy: add MediaTek PHY driver
>   net: dsa: mt7530: add interrupt support
>   dt-bindings: net: dsa: add MT7530 interrupt controller binding
>   staging: mt7621-dts: enable MT7530 interrupt controller
>
>  .../devicetree/bindings/net/dsa/mt7530.txt    |   5 +
>  drivers/net/dsa/Kconfig                       |   1 +
>  drivers/net/dsa/mt7530.c                      | 266 ++++++++++++++++--
>  drivers/net/dsa/mt7530.h                      |  20 +-
>  drivers/net/phy/Kconfig                       |   5 +
>  drivers/net/phy/Makefile                      |   1 +
>  drivers/net/phy/mediatek.c                    | 112 ++++++++
>  drivers/staging/mt7621-dts/mt7621.dtsi        |   3 +
>  8 files changed, 384 insertions(+), 29 deletions(-)
>  create mode 100644 drivers/net/phy/mediatek.c
>
> --
> 2.25.1

I already tested v2 which works fine.
v3 works too.

Tested on Ubiquiti ER-X-SFP (MT7621) with 1 external phy which uses irq=POLL.

See dmesg log:

[   12.045645] mt7530 mdio-bus:1f eth0 (uninitialized): PHY  
[mt7530-0:00] driver [MediaTek MT7530 PHY] (irq=24)
[   12.425643] mt7530 mdio-bus:1f eth1 (uninitialized): PHY  
[mt7530-0:01] driver [MediaTek MT7530 PHY] (irq=25)
[   12.745642] mt7530 mdio-bus:1f eth2 (uninitialized): PHY  
[mt7530-0:02] driver [MediaTek MT7530 PHY] (irq=26)
[   13.065656] mt7530 mdio-bus:1f eth3 (uninitialized): PHY  
[mt7530-0:03] driver [MediaTek MT7530 PHY] (irq=27)
[   13.445657] mt7530 mdio-bus:1f eth4 (uninitialized): PHY  
[mt7530-0:04] driver [MediaTek MT7530 PHY] (irq=28)
[   13.785656] mt7530 mdio-bus:1f eth5 (uninitialized): PHY  
[mdio-bus:07] driver [Qualcomm Atheros AR8031/AR8033] (irq=POLL)

Tested-by: René van Dorst <opensource@xxxxxxxxxx>

Greats,

René