Re: [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not just 2"

[Sven Van Asbroeck]

Hi George,

On Thu, Apr 8, 2021 at 1:36 PM George McCollister
<george.mccollister@xxxxxxxxx> wrote:
>
> Can you explain the difference in behavior with what I was observing
> on the LAN7431?

I'm not using DSA in my application, so I cannot test or replicate
what you were observing. It would be great if we could work together
and settle on a solution that is acceptable to both of us.

> I'll retest but if this is reverted I'm going to start
> seeing 2 extra bytes on the end of frames and it's going to break DSA
> with the LAN7431 again.
>

Seen from my point of view, your patch is a regression. But perhaps my
patch set is a regression for you? Catch 22...

Would you be able to identify which patch broke your DSA behaviour?
Was it one of mine? Perhaps we can start from there.

Sven