Re: [PATCH] usb: dwc2: Enable RPi in ACPI mode

[kernel test robot]

Hi jlinton,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on peter.chen-usb/for-usb-next balbi-usb/testing/next v5.12-rc6 next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/jlinton/usb-dwc2-Enable-RPi-in-ACPI-mode/20210408-112405
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-a014-20210408 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 56ea2e2fdd691136d5e6631fa0e447173694b82c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/09dcd4fc8628ed453434dee372e69ec8e5d3d338
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review jlinton/usb-dwc2-Enable-RPi-in-ACPI-mode/20210408-112405
        git checkout 09dcd4fc8628ed453434dee372e69ec8e5d3d338
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc2/params.c:236:15: warning: incompatible pointer to integer conversion initializing 'kernel_ulong_t' (aka 'unsigned long') with an expression of type 'void (struct dwc2_hsotg *)' [-Wint-conversion]
           { "BCM2848", dwc2_set_bcm_params },
                        ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc2/params.c:890:10: error: assigning to 'struct acpi_device_id *' from 'const struct acpi_device_id *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
                   amatch = acpi_match_device(dwc2_acpi_match, hsotg->dev);
                          ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/dwc2/params.c:892:15: warning: incompatible integer to pointer conversion assigning to 'void (*)(struct dwc2_hsotg *)' from 'kernel_ulong_t' (aka 'unsigned long') [-Wint-conversion]
                           set_params = amatch->driver_data;
                                      ^ ~~~~~~~~~~~~~~~~~~~
   2 warnings and 1 error generated.


vim +236 drivers/usb/dwc2/params.c

   234	
   235	const struct acpi_device_id dwc2_acpi_match[] = {
 > 236		{ "BCM2848", dwc2_set_bcm_params },
   237		{ },
   238	};
   239	MODULE_DEVICE_TABLE(acpi, dwc2_acpi_match);
   240	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip