Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

[Patrice CHOTARD]

Hi Laibin

On 4/9/21 4:38 AM, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Laibin Qiu <qiulaibin@xxxxxxxxxx>
> ---
>  drivers/mmc/host/sdhci-st.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>  					   "top-mmc-delay");
>  	pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(pdata->top_ioaddr)) {
> -		dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> +	if (IS_ERR(pdata->top_ioaddr))
>  		pdata->top_ioaddr = NULL;
> -	}
>  
>  	pltfm_host->clk = clk;
>  	pdata->icnclk = icnclk;
> 

Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>

Thanks
Patrice