Re: [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error
From: Thierry Reding
Date: Fri Apr 09 2021 - 07:33:17 EST
On Fri, Apr 09, 2021 at 04:28:05PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() will increase the runtime PM counter
> even it returns an error. Thus a pairing decrement is needed
> to prevent refcount leak. Fix this by replacing this API with
> pm_runtime_resume_and_get(), which will not change the runtime
> PM counter on error.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> ---
>
> Changelog:
>
> v2: - Fix another similar case in tegra_dma_synchronize().
> ---
> drivers/dma/tegra20-apb-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good:
Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature