Re: [PATCH v2] drm/panel: panel-dsi-cm: convert sysfs snprintf to sysfs_emit
From: Thierry Reding
Date: Fri Apr 09 2021 - 07:36:16 EST
On Thu, Apr 08, 2021 at 11:08:49PM +0800, Xuezhi zhang wrote:
> On Thu, 8 Apr 2021 15:14:04 +0200
> Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
>
> > On Thu, Apr 08, 2021 at 08:52:57AM +0000, Carlis wrote:
> > > From: Xuezhi Zhang <zhangxuezhi1@xxxxxxxxxx>
> > >
> > > Fix the following coccicheck warning:
> > > drivers/gpu/drm//panel/panel-dsi-cm.c:271:8-16:
> > > WARNING: use scnprintf or sprintf
> > > drivers/gpu/drm//panel/panel-dsi-cm.c:251:8-16:
> > > WARNING: use scnprintf or sprintf
> > >
> > > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@xxxxxxxxxx>
> > > ---
> > > v2: change snprint to snprintf in subject.
> > > ---
> > > drivers/gpu/drm/panel/panel-dsi-cm.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Nit: I suspect you might've just resent this from some private email
> > address, but it's kind of hard to tell because you haven't been using
> > at least the same name in both email addresses.
> >
> > However, if you're forwarding this patch on behalf of somebody else
> > you need to add your own Signed-off-by: line.
> >
> > Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
>
> Hi,
> the email address of llyz108@xxxxxxx is my private email address,
> and zhangxuezhi@xxxxxxxxx is my company email address, and Carlis is
> my English name ,Xuezhi Zhang is my Chinese name, i will use the
> Chinese name to send the emails and patchs in the future.
>
> thanks,
It's not a big deal, I'm just mentioning it because it can confuse
people. Yes, using the same name in either case is usually a good way to
make people realize what's going on.
Thierry
Attachment:
signature.asc
Description: PGP signature