Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

[Sergei Shtylyov]

On 4/9/21 4:54 PM, angkery wrote:

> From: Junlin Yang <yangjunlin@xxxxxxxxxx>
> 
> The return from the call to platform_get_irq() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', so making 'irq' an int, and change the position to
> keep the code format.
> 
> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> WARNING: Unsigned expression compared with zero: irq > 0

   I'd understand < 0... but > 0? What tool warned about this issue?

> Signed-off-by: Junlin Yang <yangjunlin@xxxxxxxxxx>
> ---
>  drivers/ata/pata_ixp4xx_cf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
> index abc0e87..43215a4 100644
> --- a/drivers/ata/pata_ixp4xx_cf.c
> +++ b/drivers/ata/pata_ixp4xx_cf.c
> @@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap,
>  
>  static int ixp4xx_pata_probe(struct platform_device *pdev)
>  {
> -	unsigned int irq;

   Oops, not sure how I missed that. :-/
   Thanks for fixing my overlook. :-)

[...]

MBR, Sergei