Re: [PATCH 3/8] dt-bindings: apu: Add MT8192 APU power domain

From: Rob Herring
Date: Fri Apr 09 2021 - 14:23:44 EST


On Wed, Apr 07, 2021 at 11:28:01AM +0800, Flora Fu wrote:
> Create MT8192 APU power domain bindings.
> Add top power domain id.
>
> Signed-off-by: Flora Fu <flora.fu@xxxxxxxxxxxx>
> ---
> include/dt-bindings/power/mt8192-apu-power.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 include/dt-bindings/power/mt8192-apu-power.h
>
> diff --git a/include/dt-bindings/power/mt8192-apu-power.h b/include/dt-bindings/power/mt8192-apu-power.h
> new file mode 100644
> index 000000000000..b821bd4811a6
> --- /dev/null
> +++ b/include/dt-bindings/power/mt8192-apu-power.h
> @@ -0,0 +1,11 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * Copyright (c) 2021 MediaTek Inc.
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_MT8192_APU_POWER_H
> +#define _DT_BINDINGS_POWER_MT8192_APU_POWER_H
> +
> +#define MT8192_POWER_DOMAIN_APUSYS_TOP 0

Really, you don't know what the other power domains are? Please make
this as complete as possible. These headers create a merge mess.

Rob