Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

From: Andy Shevchenko
Date: Sun Apr 11 2021 - 14:08:49 EST


On Sun, Apr 11, 2021 at 9:07 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Sun, Apr 11, 2021 at 5:53 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > On Wed, 7 Apr 2021 23:51:47 +0530
> > Puranjay Mohan <puranjay12@xxxxxxxxx> wrote:

> Good point, but better is to use clamp_t(s16, ...) rather than explicit casting.

Sorry, I meant clamp_t(int, ...) of course, otherwise it will give wrong values.

> I always consider explicit casting in C (and esp. in Linux kernel) is
> a red flag. Should be really rarely needed.



--
With Best Regards,
Andy Shevchenko