Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove function

[Fabio M. De Francesco]

On Monday, April 12, 2021 11:42:51 AM CEST Greg KH wrote:
> On Sun, Apr 11, 2021 at 08:48:13PM +0200, Fabio M. De Francesco wrote:
> > Remove cmpk_handle_query_config_rx() because it just initializes a
> > local
> > variable and then returns "void".
> > 
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > ---
> > 
> >  drivers/staging/rtl8192u/r819xU_cmdpkt.c | 40 ------------------------
> >  1 file changed, 40 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> > b/drivers/staging/rtl8192u/r819xU_cmdpkt.c index
> > 4cece40a92f6..d5a54c2d3086 100644
> > --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> > +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> > @@ -249,46 +249,6 @@ static void cmpk_handle_interrupt_status(struct
> > net_device *dev, u8 *pmsg)> 
> >  	DMESG("<---- cmpk_handle_interrupt_status()\n");
> >  
> >  }
> > 
> > -/*--------------------------------------------------------------------
> > --------- - * Function:    cmpk_handle_query_config_rx()
> > - *
> > - * Overview:    The function is responsible for extract the message
> > from - *		firmware. It will contain dedicated info in
> > - *		ws-06-0063-rtl8190-command-packet-specification. 
Please
> > - *		refer to chapter "Beacon State Element".
> > - *
> > - * Input:       u8    *pmsg	-	Message Pointer of the 
command packet.
> > - *
> > - * Output:      NONE
> > - *
> > - * Return:      NONE
> > - *
> > - * Revised History:
> > - *  When		Who	Remark
> > - *  05/12/2008		amy	Create Version 0 porting from 
windows code.
> > - *
> > -
> > *---------------------------------------------------------------------
> > ------ - */
> > -static void cmpk_handle_query_config_rx(struct net_device *dev, u8
> > *pmsg) -{
> > -	struct cmpk_query_cfg	rx_query_cfg;
> > -
> > -	/* 1. Extract TX feedback info from RFD to temp structure 
buffer. */
> > -	/* It seems that FW use big endian(MIPS) and DRV use little 
endian in
> > -	 * windows OS. So we have to read the content byte by byte or
> > transfer
> > -	 * endian type before copy the message copy.
> > -	 */
> > -	rx_query_cfg.cfg_action		= (pmsg[4] & 0x80) >> 7;
> > -	rx_query_cfg.cfg_type		= (pmsg[4] & 0x60) >> 5;
> > -	rx_query_cfg.cfg_size		= (pmsg[4] & 0x18) >> 3;
> > -	rx_query_cfg.cfg_page		= (pmsg[6] & 0x0F) >> 0;
> > -	rx_query_cfg.cfg_offset		= pmsg[7];
> > -	rx_query_cfg.value		= (pmsg[8]  << 24) | 
(pmsg[9]  << 16) |
> > -					  (pmsg[10] <<  8) 
| (pmsg[11] <<  0);
> > -	rx_query_cfg.mask		= (pmsg[12] << 24) | 
(pmsg[13] << 16) |
> > -					  (pmsg[14] <<  8) 
| (pmsg[15] <<  0);
> > -}
> > -
> > 
> >  /*--------------------------------------------------------------------
> >  --------->  
> >   * Function:	cmpk_count_tx_status()
> >   *
> 
> Always test-build your patches as they can not break the build.  You
> obviously did not do that here, why not?
>
I can't see that where the build of rtl8192u is broken. 
The following lines are from the compilation log:

git/kernels/staging> make -j8 drivers/staging/rtl8192u/
 [...]
 CC [M]  drivers/staging/rtl8192u/r819xU_cmdpkt.o
 CC [M]  drivers/staging/rtl8192u/r819xU_cmdpkt.o
 [...]
 LD [M]  drivers/staging/rtl8192u/r8192u_usb.o

No errors are reported.

What am I missing?

Thanks,

Fabio
> 
> thanks,
> 
> greg k-h