Re: [PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()

[Chun-Kuang Hu]

Hi, Wang:

Wang Li <wangli74@xxxxxxxxxx> 於 2021年4月10日 週六 上午11:31寫道：
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>

>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wang Li <wangli74@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index 54ab3a324752..f1954242d8f6 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
>                 drm_connector_list_iter_end(&conn_iter);
>         }
>
> -       ret = pm_runtime_get_sync(crtc->dev->dev);
> +       ret = pm_runtime_resume_and_get(crtc->dev->dev);
>         if (ret < 0) {
>                 DRM_ERROR("Failed to enable power domain: %d\n", ret);
>                 return ret;
> --
> 2.17.1
>