Re: [PATCH v1 1/1] ACPI: utils: Document for_each_acpi_dev_match() macro
From: Andy Shevchenko
Date: Mon Apr 12 2021 - 13:50:48 EST
On Mon, Apr 12, 2021 at 8:27 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Sat, Apr 10, 2021 at 3:29 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> >
> > The macro requires to call acpi_dev_put() on each iteration.
> > Due to this it doesn't tolerate sudden disappearence of the devices.
And should be "disappearance" :-)
> >
> > Document all these nuances to prevent users blindly call it without
> > understanding the possible issues.
> >
> > While at it, add the note to the acpi_dev_get_next_match_dev() and
> > advertise acpi_dev_put() instead of put_device() in the whole family
> > of the helper functions.
Thanks for reviewing this, I'll address all in v2.
--
With Best Regards,
Andy Shevchenko