Re: [PATCH 1/5] mm/memcg: Pass both memcg and lruvec to mod_memcg_lruvec_state()

[Waiman Long]

On 4/12/21 2:04 PM, Roman Gushchin wrote:
> On Fri, Apr 09, 2021 at 07:18:38PM -0400, Waiman Long wrote:
> > The caller of mod_memcg_lruvec_state() has both memcg and lruvec readily
> > available. So both of them are now passed to mod_memcg_lruvec_state()
> > and __mod_memcg_lruvec_state(). The __mod_memcg_lruvec_state() is
> > updated to allow either of the two parameters to be set to null. This
> > makes mod_memcg_lruvec_state() equivalent to mod_memcg_state() if lruvec
> > is null.
> This patch seems to be correct, but it's a bit hard to understand why
> it's required without looking into the rest of the series. Can you, please,
> add a couple of words about it? E.g. we need it to handle stats which do not
> exist on the lruvec level...
>
> Otherwise,
> Acked-by: Roman Gushchin <guro@xxxxxx>

Good point. Will update the commit log to indicate the change is needed 
for the subsequent patch.

Cheers,
Longman