Re: [Outreachy kernel][PATCH 4/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_resizer.c

From: kernel test robot
Date: Mon Apr 12 2021 - 21:50:16 EST


Hi Aline,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f2f560e1bdc055a6a306e6b7823ba589794e6564
config: mips-randconfig-r013-20210412 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/82d48fcd5db8ca859bb928988c9b85d32e1eadbd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
git checkout 82d48fcd5db8ca859bb928988c9b85d32e1eadbd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/staging/media/omap4iss/iss_resizer.c:35:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_resizer.c:35:30: error: expected ')'
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_resizer.c:35:2: note: to match this '('
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_resizer.c:41:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_resizer.c:41:30: error: expected ')'
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_resizer.c:41:2: note: to match this '('
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_resizer.c:51:26: error: use of undeclared identifier 'SYSCONFIG'
rsz_print_register(iss, SYSCONFIG);
^
drivers/staging/media/omap4iss/iss_resizer.c:52:26: error: use of undeclared identifier 'IN_FIFO_CTRL'
rsz_print_register(iss, IN_FIFO_CTRL);
^
drivers/staging/media/omap4iss/iss_resizer.c:53:26: error: use of undeclared identifier 'FRACDIV'
rsz_print_register(iss, FRACDIV);
^
drivers/staging/media/omap4iss/iss_resizer.c:54:26: error: use of undeclared identifier 'SRC_EN'
rsz_print_register(iss, SRC_EN);
^
drivers/staging/media/omap4iss/iss_resizer.c:55:26: error: use of undeclared identifier 'SRC_MODE'
rsz_print_register(iss, SRC_MODE);
^
drivers/staging/media/omap4iss/iss_resizer.c:56:26: error: use of undeclared identifier 'SRC_FMT0'
rsz_print_register(iss, SRC_FMT0);
^
drivers/staging/media/omap4iss/iss_resizer.c:57:26: error: use of undeclared identifier 'SRC_FMT1'
rsz_print_register(iss, SRC_FMT1);
^
drivers/staging/media/omap4iss/iss_resizer.c:58:26: error: use of undeclared identifier 'SRC_VPS'
rsz_print_register(iss, SRC_VPS);
^
drivers/staging/media/omap4iss/iss_resizer.c:59:26: error: use of undeclared identifier 'SRC_VSZ'
rsz_print_register(iss, SRC_VSZ);
^
drivers/staging/media/omap4iss/iss_resizer.c:60:26: error: use of undeclared identifier 'SRC_HPS'
rsz_print_register(iss, SRC_HPS);
^
drivers/staging/media/omap4iss/iss_resizer.c:61:26: error: use of undeclared identifier 'SRC_HSZ'
rsz_print_register(iss, SRC_HSZ);
^
drivers/staging/media/omap4iss/iss_resizer.c:62:26: error: use of undeclared identifier 'DMA_RZA'
rsz_print_register(iss, DMA_RZA);
^
drivers/staging/media/omap4iss/iss_resizer.c:63:26: error: use of undeclared identifier 'DMA_RZB'
rsz_print_register(iss, DMA_RZB);
^
drivers/staging/media/omap4iss/iss_resizer.c:64:26: error: use of undeclared identifier 'DMA_STA'
rsz_print_register(iss, DMA_STA);
^
>> drivers/staging/media/omap4iss/iss_resizer.c:65:26: error: use of undeclared identifier 'GCK_MMR'
rsz_print_register(iss, GCK_MMR);
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.


vim +/GCK_MMR +65 drivers/staging/media/omap4iss/iss_resizer.c

44
45 static void resizer_print_status(struct iss_resizer_device *resizer)
46 {
47 struct iss_device *iss = to_iss_device(resizer);
48
49 dev_dbg(iss->dev, "-------------RESIZER Register dump-------------\n");
50
51 rsz_print_register(iss, SYSCONFIG);
52 rsz_print_register(iss, IN_FIFO_CTRL);
53 rsz_print_register(iss, FRACDIV);
54 rsz_print_register(iss, SRC_EN);
55 rsz_print_register(iss, SRC_MODE);
56 rsz_print_register(iss, SRC_FMT0);
57 rsz_print_register(iss, SRC_FMT1);
58 rsz_print_register(iss, SRC_VPS);
59 rsz_print_register(iss, SRC_VSZ);
60 rsz_print_register(iss, SRC_HPS);
61 rsz_print_register(iss, SRC_HSZ);
> 62 rsz_print_register(iss, DMA_RZA);
63 rsz_print_register(iss, DMA_RZB);
64 rsz_print_register(iss, DMA_STA);
> 65 rsz_print_register(iss, GCK_MMR);
66 rsz_print_register(iss, GCK_SDR);
67 rsz_print_register(iss, IRQ_RZA);
68 rsz_print_register(iss, IRQ_RZB);
69 rsz_print_register(iss, YUV_Y_MIN);
70 rsz_print_register(iss, YUV_Y_MAX);
71 rsz_print_register(iss, YUV_C_MIN);
72 rsz_print_register(iss, YUV_C_MAX);
73 rsz_print_register(iss, SEQ);
74
75 rza_print_register(iss, EN);
76 rza_print_register(iss, MODE);
77 rza_print_register(iss, 420);
78 rza_print_register(iss, I_VPS);
79 rza_print_register(iss, I_HPS);
80 rza_print_register(iss, O_VSZ);
81 rza_print_register(iss, O_HSZ);
82 rza_print_register(iss, V_PHS_Y);
83 rza_print_register(iss, V_PHS_C);
84 rza_print_register(iss, V_DIF);
85 rza_print_register(iss, V_TYP);
86 rza_print_register(iss, V_LPF);
87 rza_print_register(iss, H_PHS);
88 rza_print_register(iss, H_DIF);
89 rza_print_register(iss, H_TYP);
90 rza_print_register(iss, H_LPF);
91 rza_print_register(iss, DWN_EN);
92 rza_print_register(iss, SDR_Y_BAD_H);
93 rza_print_register(iss, SDR_Y_BAD_L);
94 rza_print_register(iss, SDR_Y_SAD_H);
95 rza_print_register(iss, SDR_Y_SAD_L);
96 rza_print_register(iss, SDR_Y_OFT);
97 rza_print_register(iss, SDR_Y_PTR_S);
98 rza_print_register(iss, SDR_Y_PTR_E);
99 rza_print_register(iss, SDR_C_BAD_H);
100 rza_print_register(iss, SDR_C_BAD_L);
101 rza_print_register(iss, SDR_C_SAD_H);
102 rza_print_register(iss, SDR_C_SAD_L);
103 rza_print_register(iss, SDR_C_OFT);
104 rza_print_register(iss, SDR_C_PTR_S);
105 rza_print_register(iss, SDR_C_PTR_E);
106
107 dev_dbg(iss->dev, "-----------------------------------------------\n");
108 }
109

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip