Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI

From: Mark Brown
Date: Tue Apr 13 2021 - 09:10:12 EST


On Tue, Apr 13, 2021 at 08:59:02PM +0800, Jay Fang wrote:
> On 2021/4/13 20:47, Mark Brown wrote:
> > On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:

> >> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
> >> Kunpeng SoCs. Hence add a dependency on ARCH_HISI, to prevent asking
> >> the user about this driver when configuring a kernel without Hisilicon
> >> platform support.

> > Are you *sure* about this? HiSilicon produce a wide range of SoCs with
> > very diverse target markets, this driver looks like it's for enterprise
> > stuff while most things guarded by that config option look like they're
> > for embedded applications.

> SPI_HISI_KUNPENG does not depend on ARCH_HISI.

Right, but that's what Geert is proposing to change - the question is
does it make sense to do so or not?

Attachment: signature.asc
Description: PGP signature