Re: [PATCH] ASoC: cs35l35: Fix an error handling path in 'cs35l35_i2c_probe()'

[Christophe JAILLET]

Le 13/04/2021 à 14:43, Mark Brown a écrit :
> On Sun, Apr 11, 2021 at 02:51:06PM +0200, Christophe JAILLET wrote:
> > If 'devm_regmap_init_i2c()' fails, there is no need to goto err. We should
> > return directly as already done by the surrounding error handling paths.
>
> These are stylistic improvements rather than bug fixes so it's probably
> better not to call them fixes.

Ok, agreed.
The error handling path is a no-op in such a case.

What do you prefer:
  - you fix the subject?
  - I send a v2 with a new subject?
  - we leave it as-is as this patch is a no-op in the real world? So it 
doesn't really mater.

CJ