Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h

[Helge Deller]

On 4/13/21 5:46 PM, Christoph Hellwig wrote:
> On Tue, Apr 13, 2021 at 05:43:18PM +0200, Helge Deller wrote:
> > On 4/12/21 10:55 AM, Christoph Hellwig wrote:
> > > The F_GETLK64/F_SETLK64/F_SETLKW64 commands are only implemented for
> > > 32-bit syscall APIs, but we also need them for compat handling on 64-bit
> > > kernels.
> >
> > Ok.
> >
> > > Given that redefining them is rather error prone, as shown by parisc
> > > getting the opcodes wrong currently, just use the existing definitions
> > > for the compat handling.
> >
> > Can you please show me where parisc gets it currently wrong?
> > I'm somehow blind to see it and of course I'd like to fix it in
> > stable kernel series if that's true...
>
> Looking again I think my comment was wrong, I thought parisc would
> fall back to the asm-generic version with different code points for
> the compat case, but parisc actually already defines the constants
> unconditionally like this patch does for everyone else.  So I'll
> retract that part of the comment.

Ok, good.
Thanks for checking!

Helge