Re: [PATCH] sched: remove the redundant comments
From: Steven Rostedt
Date: Tue Apr 13 2021 - 12:28:09 EST
On Tue, 13 Apr 2021 10:36:07 +0200
Dietmar Eggemann <dietmar.eggemann@xxxxxxx> wrote:
> > @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> > struct rq {
> > /* runqueue lock: */
> > raw_spinlock_t lock;
> > -
> > - /*
> > - * nr_running and cpu_load should be in the same cacheline because
> > - * remote CPUs use both these fields when doing load calculation.
> > - */
> > unsigned int nr_running;
> > #ifdef CONFIG_NUMA_BALANCING
> > unsigned int nr_numa_running;
>
> I forgot to remove this snippet back then. LGTM.
>
> Add a
>
> Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
>
> line.
It's just removing a comment. Should it really need a "Fixes" tag, which
will cause many people to look at it to determine if it should be
backported to stable?
-- Steve