Re: [PATCH v1 4/4] i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource()

[Chris Packham]

On 14/04/21 2:37 am, Andy Shevchenko wrote:
> devm_platform_ioremap_resource() prints a message in case of error.
> Drop custom one.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> ---
>   drivers/i2c/busses/i2c-mpc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> index ec9d7d93e80f..684a8cd17efd 100644
> --- a/drivers/i2c/busses/i2c-mpc.c
> +++ b/drivers/i2c/busses/i2c-mpc.c
> @@ -664,10 +664,8 @@ static int fsl_i2c_probe(struct platform_device *op)
>   	init_waitqueue_head(&i2c->queue);
>   
>   	i2c->base = devm_platform_ioremap_resource(op, 0);
> -	if (IS_ERR(i2c->base)) {
> -		dev_err(i2c->dev, "failed to map controller\n");
> +	if (IS_ERR(i2c->base))
>   		return PTR_ERR(i2c->base);
> -	}
>   
>   	i2c->irq = platform_get_irq(op, 0);
>   	if (i2c->irq < 0)