Re: [PATCH v1 1/3] dt-bindings: arm: imx: Add i.mx6q DaSheng COM-9XX SBC board dts support
From: dillon min
Date: Wed Apr 14 2021 - 02:41:15 EST
On Wed, Apr 14, 2021 at 2:22 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>
> On 14/04/2021 08:13, dillon.minfei@xxxxxxxxx wrote:
> > From: dillon min <dillon.minfei@xxxxxxxxx>
> >
> > The DaSheng Com-9xx is and ARM based signle board computer (SBC)
> > featuring:
> > - i.MX6Q
> > - 2GiB LPDDR3 DRAM
> > - 8GiB eMMC 5.0 FLASH
> > - 4MiB SPI Flash
> > - USB 2.0 Host/Device
> > - Multiple multi-protocol RS232/RS485 Serial ports
> > - microSD socket
> > - 5V DC power input
> > - HDMI1.4a,1080p@60
> > - RGMIIx1 Gigabit Ethernet
> > - CSI0x1, connect with ov2659
> >
> > Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 297c87f45db8..24bdfbd4853f 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -206,6 +206,7 @@ properties:
> > - fsl,imx6q-sabreauto
> > - fsl,imx6q-sabrelite
> > - fsl,imx6q-sabresd
> > + - ds,imx6q-sbc # Da Sheng COM-9XX Modules
> > - karo,imx6q-tx6q # Ka-Ro electronics TX6Q Modules
> > - kiebackpeter,imx6q-tpc # K+P i.MX6 Quad TPC Board
> > - kontron,imx6q-samx6i # Kontron i.MX6 Dual/Quad SMARC Module
> >
>
> You miss change in vendor prefixes. Didn't checkpatch complain about it?
> Did you run checkpatch?
Yes. was checked with checkpatch, since it's a warning, i forget to
fix it.thanks.
Will add vendor prefixes to vendor-prefixes.yaml in v2
Thanks.
Dillon,
> Best regards,
> Best regards,
> Krzysztof