Re: [PATCH v10 1/3] PCI: portdrv: Add pcie_port_service_get_irq() function

[Kunihiko Hayashi]

Hi Jonathan,

On 2021/04/12 17:42, Jonathan Cameron wrote:
> On Sat, 10 Apr 2021 01:22:16 +0900
> Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
>
> > Add pcie_port_service_get_irq() that returns the virtual IRQ number
> > for specified portdrv service.
>
> Trivial comment inline.
>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > ---
> >   drivers/pci/pcie/portdrv.h      |  1 +
> >   drivers/pci/pcie/portdrv_core.c | 16 ++++++++++++++++
> >   2 files changed, 17 insertions(+)
> >
> > diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
> > index 2ff5724..628a3de 100644
> > --- a/drivers/pci/pcie/portdrv.h
> > +++ b/drivers/pci/pcie/portdrv.h
> > @@ -144,4 +144,5 @@ static inline void pcie_pme_interrupt_enable(struct pci_dev *dev, bool en) {}
> >   #endif /* !CONFIG_PCIE_PME */
> >   
> >   struct device *pcie_port_find_device(struct pci_dev *dev, u32 service);
> > +int pcie_port_service_get_irq(struct pci_dev *dev, u32 service);
> >   #endif /* _PORTDRV_H_ */
> > diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> > index e1fed664..b60f0f3 100644
> > --- a/drivers/pci/pcie/portdrv_core.c
> > +++ b/drivers/pci/pcie/portdrv_core.c
> > @@ -477,7 +477,22 @@ struct device *pcie_port_find_device(struct pci_dev *dev,
> >   }
> >   EXPORT_SYMBOL_GPL(pcie_port_find_device);
> >   
> > +/*
>
> /**
>
> this is kernel-doc style, so why not mark it as such?

Thank you for pointing out.
I'll apply the style to this comment.

Thank you,

---
Best Regards
Kunihiko Hayashi