Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality

[David Hildenbrand]

On 14.04.21 06:59, Oscar Salvador wrote:
> On Tue, Apr 13, 2021 at 02:33:41PM -0700, Mike Kravetz wrote:
> > > -static void prep_new_huge_page(struct hstate *h, struct page *page, int nid)
> > > +/*
> > > + * Must be called with the hugetlb lock held
> > > + */
> > > +static void __prep_account_new_huge_page(struct hstate *h, int nid)
> > > +{
> > > +	h->nr_huge_pages++;
> > > +	h->nr_huge_pages_node[nid]++;
> >
> > I would prefer if we also move setting the destructor to this routine.
> > 	set_compound_page_dtor(page, HUGETLB_PAGE_DTOR);
>
> Uhm, but that is the routine that does the accounting, it feels wrong
> here, plus...

I agree. If we want the final activation separately, it might be better 
to have it as a separate step/function like __active_new_huge_page().

--
Thanks,

David / dhildenb