Re: [PATCH v2 1/2] spi: Add DFL bus driver for Altera SPI Master

[Mark Brown]

On Tue, Apr 13, 2021 at 03:58:34PM -0700, matthew.gerlach@xxxxxxxxxxxxxxx wrote:

> +++ b/drivers/spi/spi-altera-dfl.c
> @@ -0,0 +1,222 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * DFL bus driver for Altera SPI Master
> + *

Please make the entire comment a C++ one so things look more
intentional.

> +	memset(&pdevinfo, 0, sizeof(pdevinfo));
> +
> +	pdevinfo.name = "subdev_spi_altera";
> +	pdevinfo.id = PLATFORM_DEVID_AUTO;
> +	pdevinfo.parent = dev;
> +	pdevinfo.data = &pdata;
> +	pdevinfo.size_data = sizeof(pdata);
> +
> +	return platform_device_register_full(&pdevinfo);

Don't create a platform device here, extend the spi-altera driver to
register with both DFL and platform buses.

Attachment: signature.asc
Description: PGP signature