Re: [Outreachy kernel] Re: [PATCH 1/2] staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_v4l2.c

[Dan Carpenter]

On Wed, Apr 14, 2021 at 04:39:20PM +0200, Julia Lawall wrote:
> 
> 
> On Wed, 14 Apr 2021, Dan Carpenter wrote:
> 
> > On Wed, Apr 14, 2021 at 11:06:02AM -0300, Aline Santana Cordeiro wrote:
> > > Correct identation in block of conditional statements.
> > > The function "v4l2_device_unregister_subdev()" depends on
> > > the results of the macro function "list_for_each_entry_safe()".
> > >
> > > Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@xxxxxxxxx>
> > > ---
> > >  drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> > > index 0295e2e..6d853f4 100644
> > > --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> > > +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> > > @@ -1178,7 +1178,7 @@ static void atomisp_unregister_entities(struct atomisp_device *isp)
> > >  		atomisp_mipi_csi2_unregister_entities(&isp->csi2_port[i]);
> > >
> > >  	list_for_each_entry_safe(sd, next, &isp->v4l2_dev.subdevs, list)
> > > -	v4l2_device_unregister_subdev(sd);
> > > +		v4l2_device_unregister_subdev(sd);
> > >
> >
> > It's really more common to use curly braces for list_for_each() one
> > liners.
> >
> > 	list_for_each_entry_safe(sd, next, &isp->v4l2_dev.subdevs, list) {
> > 		v4l2_device_unregister_subdev(sd);
> > 	}
> 
> A quick test with grep shows 4000 lines containing list_for_each that
> contain no {, out of 15000 lines containing list_for_each in all.
> 

Huh...  You're right.  Never mind then.

regards,
dan carpenter