Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

[Rijo Thomas]

On 14/04/21 10:16 pm, Jens Wiklander wrote:
> Hi Jiro,
> 
> On Mon, Apr 12, 2021 at 12:20 PM Rijo Thomas <Rijo-john.Thomas@xxxxxxx> wrote:
>>
>>
>>
>> On 12/04/21 1:06 pm, Jens Wiklander wrote:
>>> On Mon, Apr 5, 2021 at 11:43 AM Rijo Thomas <Rijo-john.Thomas@xxxxxxx> wrote:
>>>>
>>>> Same Trusted Application (TA) can be loaded in multiple TEE contexts.
>>>>
>>>> If it is a single instance TA, the TA should not get unloaded from AMD
>>>> Secure Processor, while it is still in use in another TEE context.
>>>>
>>>> Therefore reference count TA and unload it when the count becomes zero.
>>>>
>>>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
>>>> Reviewed-by: Devaraj Rangasamy <Devaraj.Rangasamy@xxxxxxx>
>>>> Signed-off-by: Rijo Thomas <Rijo-john.Thomas@xxxxxxx>
>>>> ---
>>>> v2:
>>>>  * Unload TA if get_ta_refcount() fails
>>>>
>>>>  drivers/tee/amdtee/amdtee_private.h | 13 ++++
>>>>  drivers/tee/amdtee/call.c           | 94 ++++++++++++++++++++++++++---
>>>>  drivers/tee/amdtee/core.c           | 15 +++--
>>>>  3 files changed, 106 insertions(+), 16 deletions(-)
>>>
>>> Looks good to me. Please address Dan's comment.
>>>
>>
>> Hi Jens,
>>
>> I have replied to Dan's comment.
>>
>> If you are okay with the current patch, request you to pull this.
> 
> By addressing the comment I meant fixing it not just replying that
> you're going to ignore it. :-)
> I can't see any reason why the preferred style shouldn't be used.
> 

:-) Sure Jens I will post patch v3 to address Dan's comment.

Thanks,
Rijo

> Cheers,
> Jens
>