[gustavoars-linux:testing/warray-bounds 1/10] net/core/flow_dissector.c:835:3: warning: 'memcpy' offset [33, 48] from the object at 'flow_keys' is out of the bounds of referenced subobject 'ipv6_src' with type '__u32[4]' {aka 'unsigned int[4]'} at offset 16

From: kernel test robot
Date: Wed Apr 14 2021 - 21:32:38 EST

Next
Previous
Messages

tree: #
If you fix the issue, Reported-by: kernel
All warnings (new
In function '__skb_flow inlined from >> net/core/flow_ 835 | memcpy(&k | ^~~~~~~~~~~~~ 836 | | --
net/ethtool/ioctl.c: >> net/ethtool/ioctl.c:492:2: 492 | memcpy(&li | ^~~~~~~~~~~~~~

vim +835 net/core/flow_dissector.c

1eed4dfb81b193 Tom Herbert d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov 59fb9b62fb6c92 Yoshiki Komachi d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov 71c99e32b92615 Stanislav d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov 59fb9b62fb6c92 Yoshiki Komachi d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov 59fb9b62fb6c92 Yoshiki Komachi 59fb9b62fb6c92 Yoshiki Komachi 59fb9b62fb6c92 Yoshiki Komachi 59fb9b62fb6c92 Yoshiki Komachi 59fb9b62fb6c92 Yoshiki Komachi 59fb9b62fb6c92 Yoshiki Komachi 59fb9b62fb6c92 Yoshiki Komachi d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov 71c99e32b92615 Stanislav 71c99e32b92615 Stanislav 71c99e32b92615 Stanislav 71c99e32b92615 Stanislav 71c99e32b92615 Stanislav 71c99e32b92615 Stanislav 71c99e32b92615 Stanislav 71c99e32b92615 Stanislav d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov 089b19a9204fc0 Stanislav 086f95682114fd Stanislav 089b19a9204fc0 Stanislav 089b19a9204fc0 Stanislav 089b19a9204fc0 Stanislav c8aa703822bf81 Stanislav c8aa703822bf81 Stanislav c8aa703822bf81 Stanislav 089b19a9204fc0 Stanislav 089b19a9204fc0 Stanislav c8aa703822bf81 Stanislav c8aa703822bf81 Stanislav 086f95682114fd Stanislav 086f95682114fd Stanislav 086f95682114fd Stanislav 086f95682114fd Stanislav 086f95682114fd Stanislav 086f95682114fd Stanislav 086f95682114fd Stanislav 086f95682114fd Stanislav 3d9f773cf2876c David Miller c8aa703822bf81 Stanislav 089b19a9204fc0 Stanislav c8aa703822bf81 Stanislav 089b19a9204fc0 Stanislav c8aa703822bf81 Stanislav c8aa703822bf81 Stanislav c8aa703822bf81 Stanislav c8aa703822bf81 Stanislav 453a940ea725d6 WANG Cong 453a940ea725d6 WANG Cong 3cbf4ffba5eeec Stanislav 453a940ea725d6 WANG Cong 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 453a940ea725d6 WANG Cong 453a940ea725d6 WANG Cong 453a940ea725d6 WANG Cong 453a940ea725d6 WANG Cong d79b3bafabc27c Bart Van Assche 1cc26450a855aa Stanislav 453a940ea725d6 WANG Cong 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 453a940ea725d6 WANG Cong 3cbf4ffba5eeec Stanislav 3cbf4ffba5eeec Stanislav 06635a35d13d42 Jiri Pirko f96533cded173b Alexander Lobakin f96533cded173b Alexander Lobakin 0744dd00c1b1be Eric Dumazet 42aecaa9bb2bd5 Tom Herbert 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko d34af823ff401c Tom Herbert f6a66927692e30 Hadar Hen Zion 3a1214e8b06317 Tom Herbert 24c590e3b0f9ee Jianbo Liu 58cff782cc55eb Guillaume Nault 58cff782cc55eb Guillaume Nault 1eed4dfb81b193 Tom Herbert 8e690ffdbcc7b5 Geert 34fad54c2537f7 Eric Dumazet 0744dd00c1b1be Eric Dumazet 690e36e726d00d David S. Miller 690e36e726d00d David S. Miller d5709f7ab77679 Hadar Hen Zion d5709f7ab77679 Hadar Hen Zion 453a940ea725d6 WANG Cong 690e36e726d00d David S. Miller 2d5716456404a1 John Crispin 8bef0af09a5415 Alexander Lobakin 8bef0af09a5415 Alexander Lobakin 43e665287f931a John Crispin 8bef0af09a5415 Alexander Lobakin 43e665287f931a John Crispin 43e665287f931a John Crispin 54fec33582aa60 Vladimir Oltean 54fec33582aa60 Vladimir Oltean 54fec33582aa60 Vladimir Oltean 2e8cb1b3db3843 Vladimir Oltean 54fec33582aa60 Vladimir Oltean 54fec33582aa60 Vladimir Oltean 54fec33582aa60 Vladimir Oltean 54fec33582aa60 Vladimir Oltean 43e665287f931a John Crispin 43e665287f931a John Crispin 43e665287f931a John Crispin 43e665287f931a John Crispin 2d5716456404a1 John Crispin 690e36e726d00d David S. Miller 690e36e726d00d David S. Miller 42aecaa9bb2bd5 Tom Herbert 42aecaa9bb2bd5 Tom Herbert 42aecaa9bb2bd5 Tom Herbert 42aecaa9bb2bd5 Tom Herbert 42aecaa9bb2bd5 Tom Herbert 42aecaa9bb2bd5 Tom Herbert 42aecaa9bb2bd5 Tom Herbert 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 06635a35d13d42 Jiri Pirko 0744dd00c1b1be Eric Dumazet d0e13a1488ad30 Willem de Bruijn 3cbf4ffba5eeec Stanislav d0e13a1488ad30 Willem de Bruijn 3cbf4ffba5eeec Stanislav d0e13a1488ad30 Willem de Bruijn 3cbf4ffba5eeec Stanislav 9b52e3f267a683 Stanislav 3cbf4ffba5eeec Stanislav 3cbf4ffba5eeec Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav a3fd7ceee05431 Jakub Sitnicki 695c12147a4018 Jakub Sitnicki a3fd7ceee05431 Jakub Sitnicki 9b52e3f267a683 Stanislav 695c12147a4018 Jakub Sitnicki 695c12147a4018 Jakub Sitnicki 695c12147a4018 Jakub Sitnicki a11c397c43d5b2 Stanislav 695c12147a4018 Jakub Sitnicki 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 695c12147a4018 Jakub Sitnicki 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 9b52e3f267a683 Stanislav 695c12147a4018 Jakub Sitnicki 695c12147a4018 Jakub Sitnicki 086f95682114fd Stanislav d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov c8aa703822bf81 Stanislav d58e468b1112dc Petar Penkov d58e468b1112dc Petar Penkov c8aa703822bf81 Stanislav d58e468b1112dc Petar Penkov 20a17bf6c04e3e David S. Miller 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko 67a900cc0436d7 Jiri Pirko c5ef188e931869 Jiri Pirko 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 2b8837aeaaa0bb Joe Perches 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 3a1214e8b06317 Tom Herbert 690e36e726d00d David S. Miller 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3797d3e8462efd Eric Dumazet 0744dd00c1b1be Eric Dumazet 3797d3e8462efd Eric Dumazet 3797d3e8462efd Eric Dumazet 918c023f29ab2d Alexander Duyck 918c023f29ab2d Alexander Duyck 06635a35d13d42 Jiri Pirko 918c023f29ab2d Alexander Duyck 918c023f29ab2d Alexander Duyck 918c023f29ab2d Alexander Duyck c3f8324188fa80 Tom Herbert c3f8324188fa80 Tom Herbert c3f8324188fa80 Tom Herbert 918c023f29ab2d Alexander Duyck 807e165dc44fd9 Tom Herbert d2126838050ccd Davide Caratti d2126838050ccd Davide Caratti d2126838050ccd Davide Caratti 807e165dc44fd9 Tom Herbert 4b36993d3df083 David S. Miller 807e165dc44fd9 Tom Herbert 807e165dc44fd9 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 807e165dc44fd9 Tom Herbert 4b36993d3df083 David S. Miller 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 807e165dc44fd9 Tom Herbert 807e165dc44fd9 Tom Herbert 807e165dc44fd9 Tom Herbert 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 2b8837aeaaa0bb Joe Perches 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 19469a873bafd4 Tom Herbert 690e36e726d00d David S. Miller 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 19469a873bafd4 Tom Herbert 20a17bf6c04e3e David S. Miller b924933cbbfbdc Jiri Pirko b3c3106ce3f464 Alexander Duyck b924933cbbfbdc Jiri Pirko b924933cbbfbdc Jiri Pirko b924933cbbfbdc Jiri Pirko b3c3106ce3f464 Alexander Duyck b3c3106ce3f464 Alexander Duyck c3f8324188fa80 Tom Herbert b924933cbbfbdc Jiri Pirko 87ee9e52ffeb16 Tom Herbert 461547f3158978 Alexander Duyck 461547f3158978 Alexander Duyck 461547f3158978 Alexander Duyck 461547f3158978 Alexander Duyck 461547f3158978 Alexander Duyck 461547f3158978 Alexander Duyck 20a17bf6c04e3e David S. Miller 87ee9e52ffeb16 Tom Herbert 87ee9e52ffeb16 Tom Herbert 87ee9e52ffeb16 Tom Herbert 06635a35d13d42 Jiri Pirko 87ee9e52ffeb16 Tom Herbert 12c227ec89a70c Jiri Pirko 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 19469a873bafd4 Tom Herbert 19469a873bafd4 Tom Herbert 518d8a2e9bad83 Or Gerlitz 518d8a2e9bad83 Or Gerlitz 518d8a2e9bad83 Or Gerlitz 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 2b8837aeaaa0bb Joe Perches 2b8837aeaaa0bb Joe Perches 24c590e3b0f9ee Jianbo Liu bc72f3dd89e087 Arnd Bergmann 2064c3d4c02026 Jianbo Liu d5709f7ab77679 Hadar Hen Zion 24c590e3b0f9ee Jianbo Liu 24c590e3b0f9ee Jianbo Liu d5709f7ab77679 Hadar Hen Zion 24c590e3b0f9ee Jianbo Liu d5709f7ab77679 Hadar Hen Zion d5709f7ab77679 Hadar Hen Zion 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert d5709f7ab77679 Hadar Hen Zion d5709f7ab77679 Hadar Hen Zion 24c590e3b0f9ee Jianbo Liu 24c590e3b0f9ee Jianbo Liu 24c590e3b0f9ee Jianbo Liu 24c590e3b0f9ee Jianbo Liu 24c590e3b0f9ee Jianbo Liu 24c590e3b0f9ee Jianbo Liu 24c590e3b0f9ee Jianbo Liu 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 24c590e3b0f9ee Jianbo Liu f6a66927692e30 Hadar Hen Zion 24c590e3b0f9ee Jianbo Liu d34af823ff401c Tom Herbert d34af823ff401c Tom Herbert 24c590e3b0f9ee Jianbo Liu f6a66927692e30 Hadar Hen Zion 9b319148cb34ec Michał f6a66927692e30 Hadar Hen Zion f6a66927692e30 Hadar Hen Zion d5709f7ab77679 Hadar Hen Zion f6a66927692e30 Hadar Hen Zion f6a66927692e30 Hadar Hen Zion f6a66927692e30 Hadar Hen Zion f6a66927692e30 Hadar Hen Zion 2064c3d4c02026 Jianbo Liu d34af823ff401c Tom Herbert d34af823ff401c Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 2b8837aeaaa0bb Joe Perches 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 690e36e726d00d David S. Miller 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 2b8837aeaaa0bb Joe Perches 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 2b8837aeaaa0bb Joe Perches 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 08bfc9cb76e26d Erik Hugne 8d6e79d3ce13e3 Jon Maloy 8d6e79d3ce13e3 Jon Maloy 8d6e79d3ce13e3 Jon Maloy 8d6e79d3ce13e3 Jon Maloy 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 06635a35d13d42 Jiri Pirko 20a17bf6c04e3e David S. Miller 8d6e79d3ce13e3 Jon Maloy 06635a35d13d42 Jiri Pirko 8d6e79d3ce13e3 Jon Maloy 06635a35d13d42 Jiri Pirko 8d6e79d3ce13e3 Jon Maloy 8d6e79d3ce13e3 Jon Maloy 06635a35d13d42 Jiri Pirko 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 08bfc9cb76e26d Erik Hugne b3baa0fbd02a1a Tom Herbert b3baa0fbd02a1a Tom Herbert 4a5d6c8b14b81e Jiri Pirko 3a1214e8b06317 Tom Herbert 4a5d6c8b14b81e Jiri Pirko 58cff782cc55eb Guillaume Nault 58cff782cc55eb Guillaume Nault 58cff782cc55eb Guillaume Nault 58cff782cc55eb Guillaume Nault 3a1214e8b06317 Tom Herbert 56193d1bce2b27 Alexander Duyck 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 224516b3a798a0 Alexander Duyck 224516b3a798a0 Alexander Duyck 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 55733350e5e8b7 Simon Horman 55733350e5e8b7 Simon Horman 9bf881ffc5c0e6 Jiri Pirko 3a1214e8b06317 Tom Herbert 9bf881ffc5c0e6 Jiri Pirko 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 5b0890a9720462 Sven Eckelmann 5b0890a9720462 Sven Eckelmann 5b0890a9720462 Sven Eckelmann 5b0890a9720462 Sven Eckelmann 5b0890a9720462 Sven Eckelmann 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 4f1cc51f34886d Eran Ben Elisha 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 9bf881ffc5c0e6 Jiri Pirko 55733350e5e8b7 Simon Horman 3a1214e8b06317 Tom Herbert 1eed4dfb81b193 Tom Herbert 3a1214e8b06317 Tom Herbert 1eed4dfb81b193 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 9bf881ffc5c0e6 Jiri Pirko 7c92de8eaabfff Jiri Pirko 9bf881ffc5c0e6 Jiri Pirko 55733350e5e8b7 Simon Horman 0744dd00c1b1be Eric Dumazet 6a74fcf426f51a Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 0744dd00c1b1be Eric Dumazet 7c92de8eaabfff Jiri Pirko 3a1214e8b06317 Tom Herbert 7c92de8eaabfff Jiri Pirko 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 6a74fcf426f51a Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 6a74fcf426f51a Tom Herbert 1e98a0f08abddd Eric Dumazet 1e98a0f08abddd Eric Dumazet 6a74fcf426f51a Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 6a74fcf426f51a Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert b840f28b908da0 Tom Herbert 4b36993d3df083 David S. Miller b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert 43d2ccb3c122a4 Alexander Duyck b840f28b908da0 Tom Herbert b840f28b908da0 Tom Herbert 4b36993d3df083 David S. Miller 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert b840f28b908da0 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert b840f28b908da0 Tom Herbert 0744dd00c1b1be Eric Dumazet fca418955148e4 Tom Herbert 823b96939578ea Tom Herbert 4b36993d3df083 David S. Miller 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 823b96939578ea Tom Herbert b438f940d3541f Tom Herbert b438f940d3541f Tom Herbert 823b96939578ea Tom Herbert 4b36993d3df083 David S. Miller 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 823b96939578ea Tom Herbert b3baa0fbd02a1a Tom Herbert b3baa0fbd02a1a Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert ac4bb5de27010e Jiri Pirko ac4bb5de27010e Jiri Pirko ac4bb5de27010e Jiri Pirko ac4bb5de27010e Jiri Pirko 3a1214e8b06317 Tom Herbert 3b336d6f4ec690 Matteo Croce 3b336d6f4ec690 Matteo Croce 3b336d6f4ec690 Matteo Croce 3b336d6f4ec690 Matteo Croce 3b336d6f4ec690 Matteo Croce 3b336d6f4ec690 Matteo Croce 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 0744dd00c1b1be Eric Dumazet 8ffb055beae585 Yoshiki Komachi 8ffb055beae585 Yoshiki Komachi 8ffb055beae585 Yoshiki Komachi 5af7fb6e3e92c2 Alexander Duyck 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 1eed4dfb81b193 Tom Herbert 3a1214e8b06317 Tom Herbert 1eed4dfb81b193 Tom Herbert 3a1214e8b06317 Tom Herbert 1eed4dfb81b193 Tom Herbert 3a1214e8b06317 Tom Herbert 1eed4dfb81b193 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert 3a1214e8b06317 Tom Herbert a6e544b0a88b53 Tom Herbert a6e544b0a88b53 Tom Herbert a6e544b0a88b53 Tom Herbert 34fad54c2537f7 Eric Dumazet d0c081b49137cd Eric Dumazet a6e544b0a88b53 Tom Herbert a6e544b0a88b53 Tom Herbert a6e544b0a88b53 Tom Herbert a6e544b0a88b53 Tom Herbert 34fad54c2537f7 Eric Dumazet 34fad54c2537f7 Eric Dumazet 34fad54c2537f7 Eric Dumazet 34fad54c2537f7 Eric Dumazet 0744dd00c1b1be Eric Dumazet 690e36e726d00d David S. Miller 441d9d327f1e77 Cong Wang
:::::: The code at :::::: d58e468b1112dcd1d51
:::::: TO: Petar :::::: CC: Alexei
---
0-DAY CI Kernel Test Attachment: Description: application/gzip message: Martin KaFai Lau: "Re: [PATCH] tools/testing: Remove unused variable" message: Taniya Das: "Re: [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming" sorted by: [ date ] [ thread ] [ subject ] [ author ] href="https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/warray-bounds
fc1b1d3ccbfdc440caca24
0162d18a7eef3ed192282a [1/10] Makefile: Enable -Warray-bounds
(attached as .config)
9.3.0-22) 9.3.0
href="https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?id=06f7d86a7f517e6ce30162d18a7eef3ed192282a">https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?id=06f7d86a7f517e6ce30162d18a7eef3ed192282a
add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
--no-tags gustavoars-linux testing/warray-bounds
06f7d86a7f517e6ce30162d18a7eef3ed192282a
attached .config to linux build tree
kindly add following tag as appropriate
test robot <lkp@xxxxxxxxx>
ones prefixed by >>):
_bpf_to_target',
'__skb_flow_dissect' at net/core/flow_dissector.c:1014:4:
dissector.c:835:3: warning: 'memcpy' offset [33, 48] from the object at 'flow_keys' is out of the bounds of referenced subobject 'ipv6_src' with type '__u32[4]' {aka 'unsigned int[4]'} at offset 16 [-Warray-bounds]
ey_addrs->v6addrs, &flow_keys->ipv6_src,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sizeof(key_addrs->v6addrs));
~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'store_link_ksettings_for_user.constprop':
warning: 'memcpy' offset [49, 84] from the object at 'link_usettings' is out of the bounds of referenced subobject 'base' with type 'struct ethtool_link_settings' at offset 0 [-Warray-bounds]
nk_usettings.base, &from->base, sizeof(link_usettings));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2017-09-01 793
2018-09-14 794 static void __skb_flow_bpf_to_target(const struct bpf_flow_keys *flow_keys,
2018-09-14 795 struct flow_dissector *flow_dissector,
2018-09-14 796 void *target_container)
2018-09-14 797 {
2020-01-17 798 struct flow_dissector_key_ports *key_ports = NULL;
2018-09-14 799 struct flow_dissector_key_control *key_control;
2018-09-14 800 struct flow_dissector_key_basic *key_basic;
2018-09-14 801 struct flow_dissector_key_addrs *key_addrs;
Fomichev 2019-07-25 802 struct flow_dissector_key_tags *key_tags;
2018-09-14 803
2018-09-14 804 key_control = skb_flow_dissector_target(flow_dissector,
2018-09-14 805 FLOW_DISSECTOR_KEY_CONTROL,
2018-09-14 806 target_container);
2018-09-14 807 key_control->thoff = flow_keys->thoff;
2018-09-14 808 if (flow_keys->is_frag)
2018-09-14 809 key_control->flags |= FLOW_DIS_IS_FRAGMENT;
2018-09-14 810 if (flow_keys->is_first_frag)
2018-09-14 811 key_control->flags |= FLOW_DIS_FIRST_FRAG;
2018-09-14 812 if (flow_keys->is_encap)
2018-09-14 813 key_control->flags |= FLOW_DIS_ENCAPSULATION;
2018-09-14 814
2018-09-14 815 key_basic = skb_flow_dissector_target(flow_dissector,
2018-09-14 816 FLOW_DISSECTOR_KEY_BASIC,
2018-09-14 817 target_container);
2018-09-14 818 key_basic->n_proto = flow_keys->n_proto;
2018-09-14 819 key_basic->ip_proto = flow_keys->ip_proto;
2018-09-14 820
2018-09-14 821 if (flow_keys->addr_proto == ETH_P_IP &&
2018-09-14 822 dissector_uses_key(flow_dissector, FLOW_DISSECTOR_KEY_IPV4_ADDRS)) {
2018-09-14 823 key_addrs = skb_flow_dissector_target(flow_dissector,
2018-09-14 824 FLOW_DISSECTOR_KEY_IPV4_ADDRS,
2018-09-14 825 target_container);
2018-09-14 826 key_addrs->v4addrs.src = flow_keys->ipv4_src;
2018-09-14 827 key_addrs->v4addrs.dst = flow_keys->ipv4_dst;
2018-09-14 828 key_control->addr_type = FLOW_DISSECTOR_KEY_IPV4_ADDRS;
2018-09-14 829 } else if (flow_keys->addr_proto == ETH_P_IPV6 &&
2018-09-14 830 dissector_uses_key(flow_dissector,
2018-09-14 831 FLOW_DISSECTOR_KEY_IPV6_ADDRS)) {
2018-09-14 832 key_addrs = skb_flow_dissector_target(flow_dissector,
2018-09-14 833 FLOW_DISSECTOR_KEY_IPV6_ADDRS,
2018-09-14 834 target_container);
2018-09-14 @835 memcpy(&key_addrs->v6addrs, &flow_keys->ipv6_src,
2018-09-14 836 sizeof(key_addrs->v6addrs));
2018-09-14 837 key_control->addr_type = FLOW_DISSECTOR_KEY_IPV6_ADDRS;
2018-09-14 838 }
2018-09-14 839
2020-01-17 840 if (dissector_uses_key(flow_dissector, FLOW_DISSECTOR_KEY_PORTS))
2018-09-14 841 key_ports = skb_flow_dissector_target(flow_dissector,
2018-09-14 842 FLOW_DISSECTOR_KEY_PORTS,
2018-09-14 843 target_container);
2020-01-17 844 else if (dissector_uses_key(flow_dissector,
2020-01-17 845 FLOW_DISSECTOR_KEY_PORTS_RANGE))
2020-01-17 846 key_ports = skb_flow_dissector_target(flow_dissector,
2020-01-17 847 FLOW_DISSECTOR_KEY_PORTS_RANGE,
2020-01-17 848 target_container);
2020-01-17 849
2020-01-17 850 if (key_ports) {
2018-09-14 851 key_ports->src = flow_keys->sport;
2018-09-14 852 key_ports->dst = flow_keys->dport;
2018-09-14 853 }
Fomichev 2019-07-25 854
Fomichev 2019-07-25 855 if (dissector_uses_key(flow_dissector,
Fomichev 2019-07-25 856 FLOW_DISSECTOR_KEY_FLOW_LABEL)) {
Fomichev 2019-07-25 857 key_tags = skb_flow_dissector_target(flow_dissector,
Fomichev 2019-07-25 858 FLOW_DISSECTOR_KEY_FLOW_LABEL,
Fomichev 2019-07-25 859 target_container);
Fomichev 2019-07-25 860 key_tags->flow_label = ntohl(flow_keys->flow_label);
Fomichev 2019-07-25 861 }
2018-09-14 862 }
2018-09-14 863
Fomichev 2019-04-22 864 bool bpf_flow_dissect(struct bpf_prog *prog, struct bpf_flow_dissector *ctx,
Fomichev 2019-07-25 865 __be16 proto, int nhoff, int hlen, unsigned int flags)
Fomichev 2019-04-22 866 {
Fomichev 2019-04-22 867 struct bpf_flow_keys *flow_keys = ctx->flow_keys;
Fomichev 2019-04-22 868 u32 result;
Fomichev 2019-01-28 869
Fomichev 2019-01-28 870 /* Pass parameters to the BPF program */
Fomichev 2019-01-28 871 memset(flow_keys, 0, sizeof(*flow_keys));
Fomichev 2019-04-22 872 flow_keys->n_proto = proto;
Fomichev 2019-04-22 873 flow_keys->nhoff = nhoff;
Fomichev 2019-01-28 874 flow_keys->thoff = flow_keys->nhoff;
Fomichev 2019-01-28 875
Fomichev 2019-07-25 876 BUILD_BUG_ON((int)BPF_FLOW_DISSECTOR_F_PARSE_1ST_FRAG !=
Fomichev 2019-07-25 877 (int)FLOW_DISSECTOR_F_PARSE_1ST_FRAG);
Fomichev 2019-07-25 878 BUILD_BUG_ON((int)BPF_FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL !=
Fomichev 2019-07-25 879 (int)FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL);
Fomichev 2019-07-25 880 BUILD_BUG_ON((int)BPF_FLOW_DISSECTOR_F_STOP_AT_ENCAP !=
Fomichev 2019-07-25 881 (int)FLOW_DISSECTOR_F_STOP_AT_ENCAP);
Fomichev 2019-07-25 882 flow_keys->flags = flags;
Fomichev 2019-07-25 883
2020-02-24 884 result = bpf_prog_run_pin_on_cpu(prog, ctx);
Fomichev 2019-01-28 885
Fomichev 2019-04-22 886 flow_keys->nhoff = clamp_t(u16, flow_keys->nhoff, nhoff, hlen);
Fomichev 2019-01-28 887 flow_keys->thoff = clamp_t(u16, flow_keys->thoff,
Fomichev 2019-04-22 888 flow_keys->nhoff, hlen);
Fomichev 2019-01-28 889
Fomichev 2019-01-28 890 return result == BPF_OK;
Fomichev 2019-01-28 891 }
Fomichev 2019-01-28 892
2014-08-25 893 /**
2014-08-25 894 * __skb_flow_dissect - extract the flow_keys struct and return it
Fomichev 2019-04-22 895 * @net: associated network namespace, derived from @skb if NULL
2014-08-25 896 * @skb: sk_buff to extract the flow from, can be NULL if the rest are specified
2015-05-12 897 * @flow_dissector: list of keys to dissect
2015-05-12 898 * @target_container: target structure to put dissected values into
2014-08-25 899 * @data: raw buffer pointer to the packet, if NULL use skb->data
2014-08-25 900 * @proto: protocol for which to get the flow, if @data is NULL use skb->protocol
2014-08-25 901 * @nhoff: network header offset, if @data is NULL use skb_network_offset(skb)
2014-08-25 902 * @hlen: packet header length, if @data is NULL use skb_headlen(skb)
2019-03-25 903 * @flags: flags that control the dissection process, e.g.
Fomichev 2019-05-31 904 * FLOW_DISSECTOR_F_STOP_AT_ENCAP.
2014-08-25 905 *
2015-05-12 906 * The function will try to retrieve individual keys into target specified
2015-05-12 907 * by flow_dissector from either the skbuff or a raw buffer specified by the
2015-05-12 908 * rest parameters.
2015-05-12 909 *
2015-05-12 910 * Caller must take care of zeroing target container memory.
2014-08-25 911 */
Fomichev 2019-04-22 912 bool __skb_flow_dissect(const struct net *net,
Fomichev 2019-04-22 913 const struct sk_buff *skb,
2015-05-12 914 struct flow_dissector *flow_dissector,
2021-03-14 915 void *target_container, const void *data,
2021-03-14 916 __be16 proto, int nhoff, int hlen, unsigned int flags)
2011-11-28 917 {
2015-06-04 918 struct flow_dissector_key_control *key_control;
2015-05-12 919 struct flow_dissector_key_basic *key_basic;
2015-05-12 920 struct flow_dissector_key_addrs *key_addrs;
2015-06-04 921 struct flow_dissector_key_tags *key_tags;
2016-08-17 922 struct flow_dissector_key_vlan *key_vlan;
2017-09-01 923 enum flow_dissect_ret fdret;
2018-07-06 924 enum flow_dissector_key_id dissector_vlan = FLOW_DISSECTOR_KEY_MAX;
2020-05-26 925 bool mpls_el = false;
2020-05-26 926 int mpls_lse = 0;
2017-09-01 927 int num_hdrs = 0;
Uytterhoeven 2015-06-25 928 u8 ip_proto = 0;
2016-11-09 929 bool ret;
2011-11-28 930
2014-08-23 931 if (!data) {
2014-08-23 932 data = skb->data;
2016-08-17 933 proto = skb_vlan_tag_present(skb) ?
2016-08-17 934 skb->vlan_proto : skb->protocol;
2014-08-25 935 nhoff = skb_network_offset(skb);
2014-08-23 936 hlen = skb_headlen(skb);
2017-08-10 937 #if IS_ENABLED(CONFIG_NET_DSA)
2019-12-05 938 if (unlikely(skb->dev && netdev_uses_dsa(skb->dev) &&
2019-12-05 939 proto == htons(ETH_P_XDSA))) {
2017-08-09 940 const struct dsa_device_ops *ops;
2019-12-05 941 int offset = 0;
2017-08-09 942
2017-08-09 943 ops = skb->dev->dsa_ptr->tag_ops;
2020-09-26 944 /* Tail taggers don't break flow dissection */
2020-09-26 945 if (!ops->tail_tag) {
2020-09-26 946 if (ops->flow_dissect)
2020-09-26 947 ops->flow_dissect(skb, &proto, &offset);
2020-09-26 948 else
2020-09-26 949 dsa_tag_generic_flow_dissect(skb,
2020-09-26 950 &proto,
2020-09-26 951 &offset);
2017-08-09 952 hlen -= offset;
2017-08-09 953 nhoff += offset;
2017-08-09 954 }
2017-08-09 955 }
2017-08-10 956 #endif
2014-08-23 957 }
2014-08-23 958
2015-06-04 959 /* It is ensured by skb_flow_dissector_init() that control key will
2015-06-04 960 * be always present.
2015-06-04 961 */
2015-06-04 962 key_control = skb_flow_dissector_target(flow_dissector,
2015-06-04 963 FLOW_DISSECTOR_KEY_CONTROL,
2015-06-04 964 target_container);
2015-06-04 965
2015-05-12 966 /* It is ensured by skb_flow_dissector_init() that basic key will
2015-05-12 967 * be always present.
2015-05-12 968 */
2015-05-12 969 key_basic = skb_flow_dissector_target(flow_dissector,
2015-05-12 970 FLOW_DISSECTOR_KEY_BASIC,
2015-05-12 971 target_container);
2011-11-28 972
2018-09-24 973 if (skb) {
Fomichev 2019-04-22 974 if (!net) {
2018-09-24 975 if (skb->dev)
Fomichev 2019-04-22 976 net = dev_net(skb->dev);
2018-09-24 977 else if (skb->sk)
Fomichev 2019-04-22 978 net = sock_net(skb->sk);
Fomichev 2019-04-22 979 }
Fomichev 2019-04-22 980 }
Fomichev 2019-04-22 981
Fomichev 2019-04-22 982 WARN_ON_ONCE(!net);
Fomichev 2019-04-22 983 if (net) {
2020-05-31 984 enum netns_bpf_attach_type type = NETNS_BPF_FLOW_DISSECTOR;
2020-06-25 985 struct bpf_prog_array *run_array;
2020-05-31 986
Fomichev 2019-04-22 987 rcu_read_lock();
2020-06-25 988 run_array = rcu_dereference(init_net.bpf.run_array[type]);
2020-06-25 989 if (!run_array)
2020-06-25 990 run_array = rcu_dereference(net->bpf.run_array[type]);
Fomichev 2019-10-07 991
2020-06-25 992 if (run_array) {
Fomichev 2019-04-22 993 struct bpf_flow_keys flow_keys;
Fomichev 2019-04-22 994 struct bpf_flow_dissector ctx = {
Fomichev 2019-04-22 995 .flow_keys = &flow_keys,
Fomichev 2019-04-22 996 .data = data,
Fomichev 2019-04-22 997 .data_end = data + hlen,
Fomichev 2019-04-22 998 };
Fomichev 2019-04-22 999 __be16 n_proto = proto;
2020-06-25 1000 struct bpf_prog *prog;
Fomichev 2019-04-22 1001
Fomichev 2019-04-22 1002 if (skb) {
Fomichev 2019-04-22 1003 ctx.skb = skb;
Fomichev 2019-04-22 1004 /* we can't use 'proto' in the skb case
Fomichev 2019-04-22 1005 * because it might be set to skb->vlan_proto
Fomichev 2019-04-22 1006 * which has been pulled from the data
Fomichev 2019-04-22 1007 */
Fomichev 2019-04-22 1008 n_proto = skb->protocol;
Fomichev 2019-04-22 1009 }
Fomichev 2019-04-22 1010
2020-06-25 1011 prog = READ_ONCE(run_array->items[0].prog);
2020-06-25 1012 ret = bpf_flow_dissect(prog, &ctx, n_proto, nhoff,
Fomichev 2019-07-25 1013 hlen, flags);
2018-09-14 @1014 __skb_flow_bpf_to_target(&flow_keys, flow_dissector,
2018-09-14 1015 target_container);
2018-09-14 1016 rcu_read_unlock();
Fomichev 2019-01-28 1017 return ret;
2018-09-14 1018 }
2018-09-14 1019 rcu_read_unlock();
Fomichev 2019-01-28 1020 }
2018-09-14 1021
2015-09-01 1022 if (dissector_uses_key(flow_dissector,
2015-05-12 1023 FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
2015-05-12 1024 struct ethhdr *eth = eth_hdr(skb);
2015-05-12 1025 struct flow_dissector_key_eth_addrs *key_eth_addrs;
2015-05-12 1026
2015-05-12 1027 key_eth_addrs = skb_flow_dissector_target(flow_dissector,
2015-05-12 1028 FLOW_DISSECTOR_KEY_ETH_ADDRS,
2015-05-12 1029 target_container);
2015-05-12 1030 memcpy(key_eth_addrs, &eth->h_dest, sizeof(*key_eth_addrs));
2015-05-12 1031 }
2015-05-12 1032
2017-03-06 1033 proto_again:
2017-09-01 1034 fdret = FLOW_DISSECT_RET_CONTINUE;
2017-09-01 1035
2011-11-28 1036 switch (proto) {
2014-03-12 1037 case htons(ETH_P_IP): {
2011-11-28 1038 const struct iphdr *iph;
2011-11-28 1039 struct iphdr _iph;
2017-09-01 1040
2014-08-23 1041 iph = __skb_header_pointer(skb, nhoff, sizeof(_iph), data, hlen, &_iph);
2017-09-01 1042 if (!iph || iph->ihl < 5) {
2017-09-01 1043 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1044 break;
2017-09-01 1045 }
2017-09-01 1046
2013-11-07 1047 nhoff += iph->ihl * 4;
2011-11-28 1048
2013-11-07 1049 ip_proto = iph->protocol;
2013-11-07 1050
2016-02-24 1051 if (dissector_uses_key(flow_dissector,
2016-02-24 1052 FLOW_DISSECTOR_KEY_IPV4_ADDRS)) {
2015-05-12 1053 key_addrs = skb_flow_dissector_target(flow_dissector,
2016-02-24 1054 FLOW_DISSECTOR_KEY_IPV4_ADDRS,
2016-02-24 1055 target_container);
2016-02-24 1056
2015-06-04 1057 memcpy(&key_addrs->v4addrs, &iph->saddr,
2015-06-04 1058 sizeof(key_addrs->v4addrs));
2015-06-04 1059 key_control->addr_type = FLOW_DISSECTOR_KEY_IPV4_ADDRS;
2016-02-24 1060 }
2015-09-01 1061
2021-02-12 1062 __skb_flow_dissect_ipv4(skb, flow_dissector,
2021-02-12 1063 target_container, data, iph);
2021-02-12 1064
2015-09-01 1065 if (ip_is_fragment(iph)) {
2015-09-01 1066 key_control->flags |= FLOW_DIS_IS_FRAGMENT;
2015-09-01 1067
2015-09-01 1068 if (iph->frag_off & htons(IP_OFFSET)) {
2017-09-01 1069 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1070 break;
2015-09-01 1071 } else {
2015-09-01 1072 key_control->flags |= FLOW_DIS_FIRST_FRAG;
2017-09-01 1073 if (!(flags &
2017-09-01 1074 FLOW_DISSECTOR_F_PARSE_1ST_FRAG)) {
2017-09-01 1075 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1076 break;
2017-09-01 1077 }
2015-09-01 1078 }
2015-09-01 1079 }
2015-09-01 1080
2011-11-28 1081 break;
2011-11-28 1082 }
2014-03-12 1083 case htons(ETH_P_IPV6): {
2011-11-28 1084 const struct ipv6hdr *iph;
2011-11-28 1085 struct ipv6hdr _iph;
2014-07-01 1086
2014-08-23 1087 iph = __skb_header_pointer(skb, nhoff, sizeof(_iph), data, hlen, &_iph);
2017-09-01 1088 if (!iph) {
2017-09-01 1089 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1090 break;
2017-09-01 1091 }
2011-11-28 1092
2011-11-28 1093 ip_proto = iph->nexthdr;
2011-11-28 1094 nhoff += sizeof(struct ipv6hdr);
2014-07-01 1095
2015-09-01 1096 if (dissector_uses_key(flow_dissector,
2015-05-12 1097 FLOW_DISSECTOR_KEY_IPV6_ADDRS)) {
2016-02-24 1098 key_addrs = skb_flow_dissector_target(flow_dissector,
2015-05-12 1099 FLOW_DISSECTOR_KEY_IPV6_ADDRS,
2015-05-12 1100 target_container);
2015-05-12 1101
2016-02-24 1102 memcpy(&key_addrs->v6addrs, &iph->saddr,
2016-02-24 1103 sizeof(key_addrs->v6addrs));
2015-06-04 1104 key_control->addr_type = FLOW_DISSECTOR_KEY_IPV6_ADDRS;
2015-05-12 1105 }
2015-06-04 1106
2016-02-09 1107 if ((dissector_uses_key(flow_dissector,
2016-02-09 1108 FLOW_DISSECTOR_KEY_FLOW_LABEL) ||
2016-02-09 1109 (flags & FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL)) &&
2016-02-09 1110 ip6_flowlabel(iph)) {
2016-02-09 1111 __be32 flow_label = ip6_flowlabel(iph);
2016-02-09 1112
2015-09-01 1113 if (dissector_uses_key(flow_dissector,
2015-06-04 1114 FLOW_DISSECTOR_KEY_FLOW_LABEL)) {
2015-06-04 1115 key_tags = skb_flow_dissector_target(flow_dissector,
2015-06-04 1116 FLOW_DISSECTOR_KEY_FLOW_LABEL,
2015-05-12 1117 target_container);
2015-06-04 1118 key_tags->flow_label = ntohl(flow_label);
2015-05-22 1119 }
2017-09-01 1120 if (flags & FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL) {
2017-09-01 1121 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1122 break;
2017-09-01 1123 }
2014-07-01 1124 }
2014-07-01 1125
2017-06-01 1126 __skb_flow_dissect_ipv6(skb, flow_dissector,
2017-06-01 1127 target_container, data, iph);
2017-06-01 1128
2011-11-28 1129 break;
2011-11-28 1130 }
2014-03-12 1131 case htons(ETH_P_8021AD):
2014-03-12 1132 case htons(ETH_P_8021Q): {
2018-07-06 1133 const struct vlan_hdr *vlan = NULL;
2016-10-24 1134 struct vlan_hdr _vlan;
2018-07-06 1135 __be16 saved_vlan_tpid = proto;
2016-08-17 1136
2018-07-06 1137 if (dissector_vlan == FLOW_DISSECTOR_KEY_MAX &&
2018-07-06 1138 skb && skb_vlan_tag_present(skb)) {
2016-08-17 1139 proto = skb->protocol;
2018-07-06 1140 } else {
2016-08-17 1141 vlan = __skb_header_pointer(skb, nhoff, sizeof(_vlan),
2016-08-17 1142 data, hlen, &_vlan);
2017-09-01 1143 if (!vlan) {
2017-09-01 1144 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1145 break;
2017-09-01 1146 }
2017-09-01 1147
2016-08-17 1148 proto = vlan->h_vlan_encapsulated_proto;
2016-08-17 1149 nhoff += sizeof(*vlan);
2018-07-06 1150 }
2018-07-06 1151
2018-07-06 1152 if (dissector_vlan == FLOW_DISSECTOR_KEY_MAX) {
2018-07-06 1153 dissector_vlan = FLOW_DISSECTOR_KEY_VLAN;
2018-07-06 1154 } else if (dissector_vlan == FLOW_DISSECTOR_KEY_VLAN) {
2018-07-06 1155 dissector_vlan = FLOW_DISSECTOR_KEY_CVLAN;
2018-07-06 1156 } else {
2017-09-01 1157 fdret = FLOW_DISSECT_RET_PROTO_AGAIN;
2017-09-01 1158 break;
2017-09-01 1159 }
2011-11-28 1160
2018-07-06 1161 if (dissector_uses_key(flow_dissector, dissector_vlan)) {
2016-08-17 1162 key_vlan = skb_flow_dissector_target(flow_dissector,
2018-07-06 1163 dissector_vlan,
2015-06-04 1164 target_container);
2015-06-04 1165
2018-07-06 1166 if (!vlan) {
2016-08-17 1167 key_vlan->vlan_id = skb_vlan_tag_get_id(skb);
Mirosław 2018-11-07 1168 key_vlan->vlan_priority = skb_vlan_tag_get_prio(skb);
2016-08-17 1169 } else {
2016-08-17 1170 key_vlan->vlan_id = ntohs(vlan->h_vlan_TCI) &
2016-08-17 1171 VLAN_VID_MASK;
2016-08-17 1172 key_vlan->vlan_priority =
2016-08-17 1173 (ntohs(vlan->h_vlan_TCI) &
2016-08-17 1174 VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT;
2016-08-17 1175 }
2018-07-06 1176 key_vlan->vlan_tpid = saved_vlan_tpid;
2015-06-04 1177 }
2015-06-04 1178
2017-09-01 1179 fdret = FLOW_DISSECT_RET_PROTO_AGAIN;
2017-09-01 1180 break;
2011-11-28 1181 }
2014-03-12 1182 case htons(ETH_P_PPP_SES): {
2011-11-28 1183 struct {
2011-11-28 1184 struct pppoe_hdr hdr;
2011-11-28 1185 __be16 proto;
2011-11-28 1186 } *hdr, _hdr;
2014-08-23 1187 hdr = __skb_header_pointer(skb, nhoff, sizeof(_hdr), data, hlen, &_hdr);
2017-09-01 1188 if (!hdr) {
2017-09-01 1189 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1190 break;
2017-09-01 1191 }
2017-09-01 1192
2011-11-28 1193 proto = hdr->proto;
2011-11-28 1194 nhoff += PPPOE_SES_HLEN;
2011-11-28 1195 switch (proto) {
2014-03-12 1196 case htons(PPP_IP):
2017-09-01 1197 proto = htons(ETH_P_IP);
2017-09-01 1198 fdret = FLOW_DISSECT_RET_PROTO_AGAIN;
2017-09-01 1199 break;
2014-03-12 1200 case htons(PPP_IPV6):
2017-09-01 1201 proto = htons(ETH_P_IPV6);
2017-09-01 1202 fdret = FLOW_DISSECT_RET_PROTO_AGAIN;
2017-09-01 1203 break;
2011-11-28 1204 default:
2017-09-01 1205 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1206 break;
2011-11-28 1207 }
2017-09-01 1208 break;
2011-11-28 1209 }
2015-01-22 1210 case htons(ETH_P_TIPC): {
2017-11-08 1211 struct tipc_basic_hdr *hdr, _hdr;
2017-11-08 1212
2017-11-08 1213 hdr = __skb_header_pointer(skb, nhoff, sizeof(_hdr),
2017-11-08 1214 data, hlen, &_hdr);
2017-09-01 1215 if (!hdr) {
2017-09-01 1216 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1217 break;
2017-09-01 1218 }
2015-05-12 1219
2015-09-01 1220 if (dissector_uses_key(flow_dissector,
2017-11-08 1221 FLOW_DISSECTOR_KEY_TIPC)) {
2015-05-12 1222 key_addrs = skb_flow_dissector_target(flow_dissector,
2017-11-08 1223 FLOW_DISSECTOR_KEY_TIPC,
2015-05-12 1224 target_container);
2017-11-08 1225 key_addrs->tipckey.key = tipc_hdr_rps_key(hdr);
2017-11-08 1226 key_control->addr_type = FLOW_DISSECTOR_KEY_TIPC;
2015-05-12 1227 }
2017-09-01 1228 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1229 break;
2015-01-22 1230 }
2015-06-04 1231
2015-06-04 1232 case htons(ETH_P_MPLS_UC):
2017-03-06 1233 case htons(ETH_P_MPLS_MC):
2017-09-01 1234 fdret = __skb_flow_dissect_mpls(skb, flow_dissector,
2017-03-06 1235 target_container, data,
2020-05-26 1236 nhoff, hlen, mpls_lse,
2020-05-26 1237 &mpls_el);
2020-05-26 1238 nhoff += sizeof(struct mpls_label);
2020-05-26 1239 mpls_lse++;
2017-09-01 1240 break;
2014-09-05 1241 case htons(ETH_P_FCOE):
2017-09-01 1242 if ((hlen - nhoff) < FCOE_HEADER_LEN) {
2017-09-01 1243 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1244 break;
2017-09-01 1245 }
2016-02-24 1246
2016-02-24 1247 nhoff += FCOE_HEADER_LEN;
2017-09-01 1248 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1249 break;
2017-01-11 1250
2017-01-11 1251 case htons(ETH_P_ARP):
2017-03-06 1252 case htons(ETH_P_RARP):
2017-09-01 1253 fdret = __skb_flow_dissect_arp(skb, flow_dissector,
2017-03-06 1254 target_container, data,
2017-09-01 1255 nhoff, hlen);
2017-09-01 1256 break;
2017-09-01 1257
2017-12-21 1258 case htons(ETH_P_BATMAN):
2017-12-21 1259 fdret = __skb_flow_dissect_batadv(skb, key_control, data,
2017-12-21 1260 &proto, &nhoff, hlen, flags);
2017-12-21 1261 break;
2017-12-21 1262
2021-01-12 1263 case htons(ETH_P_1588): {
2021-01-12 1264 struct ptp_header *hdr, _hdr;
2021-01-12 1265
2021-01-12 1266 hdr = __skb_header_pointer(skb, nhoff, sizeof(_hdr), data,
2021-01-12 1267 hlen, &_hdr);
2021-01-12 1268 if (!hdr) {
2021-01-12 1269 fdret = FLOW_DISSECT_RET_OUT_BAD;
2021-01-12 1270 break;
2021-01-12 1271 }
2021-01-12 1272
2021-01-12 1273 nhoff += ntohs(hdr->message_length);
2021-01-12 1274 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2021-01-12 1275 break;
2021-01-12 1276 }
2021-01-12 1277
2017-09-01 1278 default:
2017-09-01 1279 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1280 break;
2017-09-01 1281 }
2017-09-01 1282
2017-09-01 1283 /* Process result of proto processing */
2017-09-01 1284 switch (fdret) {
2017-03-06 1285 case FLOW_DISSECT_RET_OUT_GOOD:
2017-01-11 1286 goto out_good;
2017-09-01 1287 case FLOW_DISSECT_RET_PROTO_AGAIN:
2017-09-01 1288 if (skb_flow_dissect_allowed(&num_hdrs))
2017-09-01 1289 goto proto_again;
2017-09-01 1290 goto out_good;
2017-09-01 1291 case FLOW_DISSECT_RET_CONTINUE:
2017-09-01 1292 case FLOW_DISSECT_RET_IPPROTO_AGAIN:
2017-09-01 1293 break;
2017-03-06 1294 case FLOW_DISSECT_RET_OUT_BAD:
2017-03-06 1295 default:
2017-03-06 1296 goto out_bad;
2017-01-11 1297 }
2011-11-28 1298
2015-06-12 1299 ip_proto_again:
2017-09-01 1300 fdret = FLOW_DISSECT_RET_CONTINUE;
2017-09-01 1301
2011-11-28 1302 switch (ip_proto) {
2017-03-06 1303 case IPPROTO_GRE:
2017-09-01 1304 fdret = __skb_flow_dissect_gre(skb, key_control, flow_dissector,
2017-03-06 1305 target_container, data,
2017-09-01 1306 &proto, &nhoff, &hlen, flags);
2017-09-01 1307 break;
2017-09-01 1308
2015-06-12 1309 case NEXTHDR_HOP:
2015-06-12 1310 case NEXTHDR_ROUTING:
2015-06-12 1311 case NEXTHDR_DEST: {
2015-06-12 1312 u8 _opthdr[2], *opthdr;
2015-06-12 1313
2015-06-12 1314 if (proto != htons(ETH_P_IPV6))
2015-06-12 1315 break;
2015-06-12 1316
2015-06-12 1317 opthdr = __skb_header_pointer(skb, nhoff, sizeof(_opthdr),
2015-06-12 1318 data, hlen, &_opthdr);
2017-09-01 1319 if (!opthdr) {
2017-09-01 1320 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1321 break;
2017-09-01 1322 }
2015-06-12 1323
2015-06-12 1324 ip_proto = opthdr[0];
2015-06-12 1325 nhoff += (opthdr[1] + 1) << 3;
2015-06-12 1326
2017-09-01 1327 fdret = FLOW_DISSECT_RET_IPPROTO_AGAIN;
2017-09-01 1328 break;
2015-06-12 1329 }
2015-09-01 1330 case NEXTHDR_FRAGMENT: {
2015-09-01 1331 struct frag_hdr _fh, *fh;
2015-09-01 1332
2015-09-01 1333 if (proto != htons(ETH_P_IPV6))
2015-09-01 1334 break;
2015-09-01 1335
2015-09-01 1336 fh = __skb_header_pointer(skb, nhoff, sizeof(_fh),
2015-09-01 1337 data, hlen, &_fh);
2015-09-01 1338
2017-09-01 1339 if (!fh) {
2017-09-01 1340 fdret = FLOW_DISSECT_RET_OUT_BAD;
2017-09-01 1341 break;
2017-09-01 1342 }
2015-09-01 1343
2015-09-01 1344 key_control->flags |= FLOW_DIS_IS_FRAGMENT;
2015-09-01 1345
2015-09-01 1346 nhoff += sizeof(_fh);
2016-02-24 1347 ip_proto = fh->nexthdr;
2015-09-01 1348
2015-09-01 1349 if (!(fh->frag_off & htons(IP6_OFFSET))) {
2015-09-01 1350 key_control->flags |= FLOW_DIS_FIRST_FRAG;
2017-09-01 1351 if (flags & FLOW_DISSECTOR_F_PARSE_1ST_FRAG) {
2017-09-01 1352 fdret = FLOW_DISSECT_RET_IPPROTO_AGAIN;
2017-09-01 1353 break;
2015-09-01 1354 }
2017-09-01 1355 }
2017-09-01 1356
2017-09-01 1357 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1358 break;
2015-09-01 1359 }
2011-11-28 1360 case IPPROTO_IPIP:
2013-07-29 1361 proto = htons(ETH_P_IP);
2015-09-01 1362
2015-09-01 1363 key_control->flags |= FLOW_DIS_ENCAPSULATION;
2017-09-01 1364 if (flags & FLOW_DISSECTOR_F_STOP_AT_ENCAP) {
2017-09-01 1365 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1366 break;
2017-09-01 1367 }
2017-09-01 1368
2017-09-01 1369 fdret = FLOW_DISSECT_RET_PROTO_AGAIN;
2017-09-01 1370 break;
2015-09-01 1371
2013-07-29 1372 case IPPROTO_IPV6:
2013-07-29 1373 proto = htons(ETH_P_IPV6);
2015-09-01 1374
2015-09-01 1375 key_control->flags |= FLOW_DIS_ENCAPSULATION;
2017-09-01 1376 if (flags & FLOW_DISSECTOR_F_STOP_AT_ENCAP) {
2017-09-01 1377 fdret = FLOW_DISSECT_RET_OUT_GOOD;
2017-09-01 1378 break;
2017-09-01 1379 }
2017-09-01 1380
2017-09-01 1381 fdret = FLOW_DISSECT_RET_PROTO_AGAIN;
2017-09-01 1382 break;
2017-09-01 1383
2015-09-01 1384
2015-06-04 1385 case IPPROTO_MPLS:
2015-06-04 1386 proto = htons(ETH_P_MPLS_UC);
2017-09-01 1387 fdret = FLOW_DISSECT_RET_PROTO_AGAIN;
2017-09-01 1388 break;
2017-09-01 1389
2017-05-23 1390 case IPPROTO_TCP:
2017-05-23 1391 __skb_flow_dissect_tcp(skb, flow_dissector, target_container,
2017-05-23 1392 data, nhoff, hlen);
2017-05-23 1393 break;
2017-09-01 1394
2019-10-29 1395 case IPPROTO_ICMP:
2019-10-29 1396 case IPPROTO_ICMPV6:
2019-10-29 1397 __skb_flow_dissect_icmp(skb, flow_dissector, target_container,
2019-10-29 1398 data, nhoff, hlen);
2019-10-29 1399 break;
2019-10-29 1400
2011-11-28 1401 default:
2011-11-28 1402 break;
2011-11-28 1403 }
2011-11-28 1404
2019-12-03 1405 if (!(key_control->flags & FLOW_DIS_IS_FRAGMENT))
2019-12-03 1406 __skb_flow_dissect_ports(skb, flow_dissector, target_container,
2019-12-03 1407 data, nhoff, ip_proto, hlen);
2014-10-10 1408
2017-09-01 1409 /* Process result of IP proto processing */
2017-09-01 1410 switch (fdret) {
2017-09-01 1411 case FLOW_DISSECT_RET_PROTO_AGAIN:
2017-09-01 1412 if (skb_flow_dissect_allowed(&num_hdrs))
2017-09-01 1413 goto proto_again;
2017-09-01 1414 break;
2017-09-01 1415 case FLOW_DISSECT_RET_IPPROTO_AGAIN:
2017-09-01 1416 if (skb_flow_dissect_allowed(&num_hdrs))
2017-09-01 1417 goto ip_proto_again;
2017-09-01 1418 break;
2017-09-01 1419 case FLOW_DISSECT_RET_OUT_GOOD:
2017-09-01 1420 case FLOW_DISSECT_RET_CONTINUE:
2017-09-01 1421 break;
2017-09-01 1422 case FLOW_DISSECT_RET_OUT_BAD:
2017-09-01 1423 default:
2017-09-01 1424 goto out_bad;
2017-09-01 1425 }
2017-09-01 1426
2015-09-01 1427 out_good:
2015-09-01 1428 ret = true;
2015-09-01 1429
2016-11-09 1430 out:
2018-01-17 1431 key_control->thoff = min_t(u16, nhoff, skb ? skb->len : hlen);
2015-09-01 1432 key_basic->n_proto = proto;
2015-09-01 1433 key_basic->ip_proto = ip_proto;
2015-09-01 1434
2015-09-01 1435 return ret;
2016-11-09 1436
2016-11-09 1437 out_bad:
2016-11-09 1438 ret = false;
2016-11-09 1439 goto out;
2011-11-28 1440 }
2014-08-23 1441 EXPORT_SYMBOL(__skb_flow_dissect);
2013-01-21 1442
line 835 was first introduced by commit
93c0a89ff9f98b5a3e8b9 flow_dissector: implements flow dissector BPF hook
Penkov <ppenkov@xxxxxxxxxx>
Starovoitov <ast@xxxxxxxxxx>
Service, Intel Corporation
href="https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Martin KaFai Lau: "Re: [PATCH] tools/testing: Remove unused variable"
Previous message: Taniya Das: "Re: [PATCH v4 5/7] cpufreq: qcom-hw: Implement CPRh aware OSM programming"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]