Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16]

From: Greg Kroah-Hartman
Date: Thu Apr 15 2021 - 04:35:07 EST


On Wed, Apr 14, 2021 at 10:14:34PM +0300, Alexander Shishkin wrote:
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
>
> >> Using raw buffer APIs against uuid_t / guid_t.
> >
> > So you want to do that, or you do not want to do that? Totally
> > confused,
>
> My understanding is that:
> 1) generate_random_uuid() use is allegedly bad even though it's in their
> header,
> 2) poking directly at the byte array inside uuid_t is bad, even though,
> again, header.
>
> It is, indeed, not ideal.
>
> If agreeable, I'll update this patch to the below and respin the whole
> series.

You are showing that Andy wrote this, when you are the one that did :(

Anyway, I've dropped this single patch from the series and applied the
rest. Feel free to send this patch as a stand-alone one once you have
the authorship issues sorted out.

thanks,

greg k-h