Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

[Aswath Govindraju]

Hi Marc,

On 15/04/21 1:08 pm, Marc Kleine-Budde wrote:
> On 15.04.2021 11:57:20, Aswath Govindraju wrote:
>> Hi Marc,
>>
>> On 14/04/21 9:03 pm, Marc Kleine-Budde wrote:
>>> On 14.04.2021 19:35:18, Aswath Govindraju wrote:
>>>> Add binding documentation for TI TCAN104x CAN transceivers.
>>>>
>>>> Signed-off-by: Aswath Govindraju <a-govindraju@xxxxxx>
>>>> ---
>>>>  .../bindings/phy/ti,tcan104x-can.yaml         | 56 +++++++++++++++++++
>>>>  MAINTAINERS                                   |  1 +
>>>>  2 files changed, 57 insertions(+)
>>>>  create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>> new file mode 100644
>>>> index 000000000000..4abfc30a97d0
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>>>> @@ -0,0 +1,56 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#";
>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
>>>> +
>>>> +title: TCAN104x CAN TRANSCEIVER PHY
>>>> +
>>>> +maintainers:
>>>> +  - Aswath Govindraju <a-govindraju@xxxxxx>
> 
> Can you create a maintainers entry for this file with your address?

I don't see this being done for other phy yamls in the
Documentation/devicetree/bindings/phy folder. Also,
scripts/get_maintainer.pl is giving the names of maintainers after
reading the yaml files too.

Thanks,
Aswath

> 
>>>> +
>>>> +properties:
>>>> +  $nodename:
>>>> +    pattern: "^tcan104x-phy"
>>>> +
>>>> +  compatible:
>>>> +    enum:
>>>> +      - ti,tcan1042
>>>> +      - ti,tcan1043
>>>
>>> Can you ensure that the 1042 has only the standby gpio and the 1043 has both?
>>>
>>
>> In the driver, it is the way the flags have been set for ti,tcan1042 and
>> ti,tcan1043.
> 
> I was wondering if we would enforce in the DT the 1042 has exactly one
> the standby GPIO and the 1043 has exactly the standby and the enable
> GPIO.
> 
> On the other hand the HW might have pulled one or the other pin high or
> low and only one of the pins is connected to a GPIO.
> 
>>>> +
>>>> +  '#phy-cells':
>>>> +    const: 0
>>>> +
>>>> +  standby-gpios:
>>>> +    description:
>>>> +      gpio node to toggle standby signal on transceiver
>>>> +    maxItems: 1
>>>> +
>>>> +  enable-gpios:
>>>> +    description:
>>>> +      gpio node to toggle enable signal on transceiver
>>>> +    maxItems: 1
>>>> +
>>>> +  max-bitrate:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    description:
>>>> +      max bit rate supported in bps
>>>> +    minimum: 1
>>>> +
>>>> +required:
>>>> +  - compatible
>>>> +  - '#phy-cells'
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> +  - |
>>>> +    #include <dt-bindings/gpio/gpio.h>
>>>> +
>>>> +    transceiver1: tcan104x-phy {
>>>> +      compatible = "ti,tcan1043";
>>>> +      #phy-cells = <0>;
>>>> +      max-bitrate = <5000000>;
>>>> +      standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
>>>> +      enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
>>>
>>> AFAICS the enable gpio is active high.
>>>
>>
>> I will correct this in the respin.
> 
> Marc
>