Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

From: Vincent MAILHOL
Date: Thu Apr 15 2021 - 07:42:52 EST


On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 15.04.2021 09:47:23, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > There is an assignment to *netdev that is can potentially be null but the
^^
Typo: that is can -> that can

> > null check is checking netdev and not *netdev as intended. Fix this by
> > adding in the missing * operator.
> >
> > Addresses-Coverity: ("Dereference before null check")
> > Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>

Thanks Colin!