RE: [PATCH 1/5] xattr: Complete constify ->name member of "struct xattr"
From: Roberto Sassu
Date: Thu Apr 15 2021 - 08:26:11 EST
> From: Tetsuo Handa [mailto:penguin-kernel@xxxxxxxxxxxxxxxxxxx]
> Sent: Thursday, April 15, 2021 1:20 PM
> On 2021/04/15 19:04, Roberto Sassu wrote:
> > This patch completes commit 9548906b2bb7 ('xattr: Constify ->name
> member of
> > "struct xattr"'). It fixes the documentation of the inode_init_security
> > hook, by removing the xattr name from the objects that are expected to
> be
> > allocated by LSMs (only the value is allocated). Also, it removes the
> > kfree() of name and setting it to NULL in the reiserfs code.
>
> Good catch, but well, grep does not find any reiserfs_security_free() callers.
> Is reiserfs_security_free() a dead code?
Uhm, I also don't see it.
Thanks
Roberto
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Li Peng, Li Jian, Shi Yanli