Re: [PATCH v1 1/1] powerpc/papr_scm: Properly handle UUID types and API
From: Andy Shevchenko
Date: Thu Apr 15 2021 - 13:19:09 EST
On Thu, Apr 15, 2021 at 8:10 PM Vaibhav Jain <vaibhav@xxxxxxxxxxxxx> wrote:
>
>
> Thanks for the patch Andy,
>
> Unfortunately ran into a compilation issue due to missing "#include
> <asm/unaligned.h>" that provides definition for
> get_unaligned_le64(). Gcc reported following error:
>
> error: implicit declaration of function ‘get_unaligned_le64’
Right, I have not tested it (as mentioned in the comments to the patch)
> After including the necessary header file, kernel compiled fine and I
> was able to test & verify the patch.
Thank you very much for the testing.
I'm not sure what the coverage of your test is. That's why I have an
additional question below. Is the byte ordering kept the same in BE
(32- and 64-bit) cases? Because I'm worrying that I might have missed
something.
--
With Best Regards,
Andy Shevchenko