Re: [PATCH] regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler
From: Krzysztof Kozlowski
Date: Fri Apr 16 2021 - 04:45:51 EST
On Fri, 16 Apr 2021 at 06:30, <zhuguangqing83@xxxxxxxxx> wrote:
>
> From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>
>
> Coccinelle noticed:
> drivers/regulator/mt6360-regulator.c:386:8-33: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
This should be tested. There are several patches like this all over
the tree so it looks like "let's fix everything from Coccinelle"
because you ignored at least in some of the cases that the handler is
not the primary one. I am not saying that the change is bad, but
rather it looks automated.
Best regards,
Krzysztof