Re: [Outreachy kernel] [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line

From: Julia Lawall
Date: Fri Apr 16 2021 - 04:46:58 EST


> > If you're running into the 80 character limit, then it's fine to use
> > two tabs. I think we have been rejecting patches that push align the
> > parameters but push past the 80 character limit. Using one tab is
> > confusing because it makes the decalarations line up with the code.
>
> Interesting. Do you have an example of this? I've thought checkpatch.pl
> gave a warning if the line ended with an opening parenthesis no matter
> what.

Checkpatch is a perl script that searches for patterns that often indicate
code that is hard to understand. It is not a precise definition of what
is allowed in the Linux kernel. Humans have to amke compromises.

julia